Fix a bug where the patcher mistakes local names for hooks#25
Open
pants64DS wants to merge 1 commit intoDirbaio:masterfrom
Open
Fix a bug where the patcher mistakes local names for hooks#25pants64DS wants to merge 1 commit intoDirbaio:masterfrom
pants64DS wants to merge 1 commit intoDirbaio:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling the following ASM patch, GCC emits
_ZZ13hook_0200da08vE1aas a symbol for variablea.Before this fix, the patcher mistook that for a hook and tried to make a branch from the hook address to the variable. Using a lambda in a hook function could also lead to the same problem.