Introduce preliminary updates for version 3 of the API#2
Closed
a-asil-companioni wants to merge 16 commits intoDisplacement-Tracking-Matrix:mainfrom
a-asil-companioni:apiV3
Closed
Introduce preliminary updates for version 3 of the API#2a-asil-companioni wants to merge 16 commits intoDisplacement-Tracking-Matrix:mainfrom a-asil-companioni:apiV3
a-asil-companioni wants to merge 16 commits intoDisplacement-Tracking-Matrix:mainfrom
a-asil-companioni:apiV3
Conversation
- Note: The base / native pipe operator was introduced in the R 4.1.0 update. - Remove calls to import the magrittr library or calls to import the pipe specifically. - Replace existing magrittr pipe calls with the base R pipe.
- This is as opposed to using jsonlite::fromJSON(). Using httr2::resp_body_string() and then fromJSON() is not as clean as just using httr2::resp_body_json(). httr2::resp_body_json() does uses fromJSON() under the hood. - Some comments were edited or added to reflect the changes in code, particularly regarding the use of as.data.frame() and the expectation that resp_body_json(response, simplifyVector=TRUE)$result will likely be a dataframe.
- The refactoring is such that the codebase becomes more in line with the tidyverse style guide. Refactor codebase and remove unneeded comments Refactor edit
Change version from 0.0.3 to 0.1.0
withr is an R library that allows changes to state to be reverted and managed cleanly. Add withr package to DESCRIPTION file
The large deletion and emphasis on referring to the introduction just means that there's much less repetition and that the changes to the introduction vignette are reflected in what users are likely to read.
Updating CI 2 CI edit CI update CI work edit
Update Roxygen2-generated files
Edit _pkgdown.yml to reflect change in introduction.Rmd
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes:
set_subscription_key()andget_subscription_key(). One of which,get_subscription_key()is designed to work within testthat's unit tests by referring to an encrypted string (placed safely within the function definition owing to such encryption).