Conversation
- Note: The base / native pipe operator was introduced in the R 4.1.0 update. - Remove calls to import the magrittr library or calls to import the pipe specifically. - Replace existing magrittr pipe calls with the base R pipe.
- This is as opposed to using jsonlite::fromJSON(). Using httr2::resp_body_string() and then fromJSON() is not as clean as just using httr2::resp_body_json(). httr2::resp_body_json() does uses fromJSON() under the hood. - Some comments were edited or added to reflect the changes in code, particularly regarding the use of as.data.frame() and the expectation that resp_body_json(response, simplifyVector=TRUE)$result will likely be a dataframe.
- The refactoring is such that the codebase becomes more in line with the tidyverse style guide. Refactor codebase and remove unneeded comments Refactor edit
Change version from 0.0.3 to 0.1.0
withr is an R library that allows changes to state to be reverted and managed cleanly. Add withr package to DESCRIPTION file
The large deletion and emphasis on referring to the introduction just means that there's much less repetition and that the changes to the introduction vignette are reflected in what users are likely to read.
Update Roxygen2-generated files
Edit _pkgdown.yml to reflect change in introduction.Rmd
…ey() with an argument
…te README.md in with a key in the env
It is not being used.
…ks run. This is because get_subscription_key() returns an error if it is neither retrievable through the environment variable or through accessing the package encryption key (when in a testthat environment). It does not return, as had been accidentally implied, an empty string "" when neither is available. The commit uses the environment variable that the function relies on directly instead. However, one should take note that if the name of the environment variable is redefined in the function, then the environment variable specified in the logic of the Rmarkdown files should be changed as well. If the package key should be used in contexts other than that of testthat(), then the logic will need to be revisited given the complications that will introduce. For now, the simpler solution is opted for. Also, the message shown in the vignette user_guide.Rmd has been removed from README.Rmd, as it should not appear in the output of the README.
It does not seem to rely on web resources, after all; it only tests how it modifies the environment.
Though it may not be used since the package is currently archived. Unclear.
It's a nicer option than \dontrun
…ADME" This reverts commit 1d2c5c0.
This reverts commit 8e48412.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the version currently on CRAN. There are certain documentation related changes on the dev branch, but the main branch should likely be what is available on CRAN.