Support/ffi v0.12.34

.github/workflows/builds.yml

@@ -25,6 +25,7 @@ on:
     paths:
       - livekit/**
       - libwebrtc/**
+  workflow_dispatch:
 
 env:
   CARGO_TERM_COLOR: always
@@ -35,29 +36,32 @@ jobs:
       fail-fast: false
       matrix:
         include:
-          - os: windows-2019
+          - os: windows-latest
             target: x86_64-pc-windows-msvc
-          - os: windows-2019
+          - os: windows-latest
             target: aarch64-pc-windows-msvc
             #extraargs: --exclude livekit-api --exclude livekit-ffi # waiting for v0.17 of ring
-          - os: macos-13
+          - os: macos-latest
             target: x86_64-apple-darwin
-          - os: macos-13
+          - os: macos-latest
             target: aarch64-apple-darwin
-          - os: macos-13
+          - os: macos-latest
             target: aarch64-apple-ios
-          - os: macos-13
+          - os: macos-latest
             target: aarch64-apple-ios-sim
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             target: x86_64-unknown-linux-gnu
-          - os: buildjet-4vcpu-ubuntu-2204-arm
+          - os: ubuntu-24.04-arm
             target: aarch64-unknown-linux-gnu
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             target: aarch64-linux-android
-          - os: ubuntu-20.04
+            ndk_arch: aarch64-unknown-linux-musl
+          - os: ubuntu-latest
             target: armv7-linux-androideabi
-          - os: ubuntu-20.04
+            ndk_arch: arm-unknown-linux-musleabihf
+          - os: ubuntu-latest
             target: x86_64-linux-android
+            ndk_arch: x86_64-unknown-linux-musl
 
     name: Build (${{ matrix.target }})
     runs-on: ${{ matrix.os }}
@@ -67,15 +71,19 @@ jobs:
           submodules: true
 
       - name: Install linux dependencies
-        if: ${{ matrix.os == 'ubuntu-20.04' || matrix.os == 'buildjet-4vcpu-ubuntu-2204-arm'}}
+        if: ${{ matrix.os == 'ubuntu-latest' || matrix.os == 'ubuntu-24.04-arm'}}
         run: |
           sudo apt update -y
           sudo apt install -y libssl-dev libx11-dev libgl1-mesa-dev libxext-dev
 
-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          target: ${{ matrix.target }}
+      - name: Install VA-API/NVIDIA drivers for linux x64 build
+        if: ${{ matrix.os == 'ubuntu-latest'}}
+        run:  |
+          sudo apt install -y libva-dev libdrm-dev libnvidia-compute-570 libnvidia-decode-570 nvidia-cuda-dev -y
+
+      - name: Install Rust toolchain.
+        run: |
+          rustup target add ${{ matrix.target }}
 
       - name: Build (Cargo)
         if: ${{ !contains(matrix.target, 'android') }}
@@ -85,5 +93,6 @@ jobs:
       - name: Build (Android)
         if: ${{ contains(matrix.target, 'android') }}
         run: |
+          ln -sf $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/${{ matrix.ndk_arch }}/{libunwind.so,libc++abi.a} $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/
           cargo install cargo-ndk
           cargo ndk --target ${{ matrix.target }} build --release -p livekit --workspace -vv

.github/workflows/ffi-builds.yml

@@ -17,84 +17,95 @@ on:
   push:
     branches: ["main"]
     tags:
-      - "ffi-v*"
+      - "rust-sdks/livekit-ffi@*"
   workflow_dispatch:
+  workflow_call:
+    inputs:
+      tag:
+        required: false
+        type: string
 
 env:
   CARGO_TERM_COLOR: always
+  TAG_NAME: ${{ inputs.tag || github.ref_name }}
 
 jobs:
   build:
     strategy:
       fail-fast: false
       matrix:
         include:
-          - os: windows-2019
+          - os: windows-latest
             platform: windows
             dylib: livekit_ffi.dll
             target: x86_64-pc-windows-msvc
             name: ffi-windows-x86_64
-          - os: windows-2019
+          - os: windows-latest
             platform: windows
             dylib: livekit_ffi.dll
             buildargs: --no-default-features --features "native-tls" # ring 0.16 is incompatible with win aarch64
             target: aarch64-pc-windows-msvc
             name: ffi-windows-arm64
-          - os: macos-13
+          - os: macos-latest
             platform: macos
             dylib: liblivekit_ffi.dylib
             target: x86_64-apple-darwin
             macosx_deployment_target: "10.15"
             name: ffi-macos-x86_64
-          - os: macos-13
+          - os: macos-latest
             platform: macos
             dylib: liblivekit_ffi.dylib
             target: aarch64-apple-darwin
             macosx_deployment_target: "11.0" # aarch64 requires 11
             name: ffi-macos-arm64
-          - os: macos-13
+          - os: macos-latest
             platform: ios
             dylib: liblivekit_ffi.a
             target: aarch64-apple-ios
             iphoneos_deployment_target: "13.0"
             name: ffi-ios-arm64
-          - os: macos-13
+            buildargs: --no-default-features --features "rustls-tls-webpki-roots"
+          - os: macos-latest
             platform: ios
             dylib: liblivekit_ffi.a
             target: aarch64-apple-ios-sim
             iphoneos_deployment_target: "13.0"
             name: ffi-ios-sim-arm64
-          - os: ubuntu-20.04
+            buildargs: --no-default-features --features "rustls-tls-webpki-roots"
+          - os: ubuntu-latest
             platform: linux
-            build_image: quay.io/pypa/manylinux_2_28_x86_64
+            build_image: sameli/manylinux_2_28_x86_64_cuda_12.3
             dylib: liblivekit_ffi.so
             target: x86_64-unknown-linux-gnu
             name: ffi-linux-x86_64
-          - os: buildjet-4vcpu-ubuntu-2204-arm
+          - os: ubuntu-24.04-arm
             platform: linux
             build_image: quay.io/pypa/manylinux_2_28_aarch64
             dylib: liblivekit_ffi.so
             target: aarch64-unknown-linux-gnu
             name: ffi-linux-arm64
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             platform: android
             dylib: liblivekit_ffi.so
             jar: libwebrtc.jar
             target: aarch64-linux-android
+            ndk_arch: aarch64-unknown-linux-musl
             name: ffi-android-arm64
             buildargs: --no-default-features --features "rustls-tls-webpki-roots"
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             platform: android
             dylib: liblivekit_ffi.so
             jar: libwebrtc.jar
             target: armv7-linux-androideabi
+            ndk_arch: arm-unknown-linux-musleabihf
             name: ffi-android-armv7
             buildargs: --no-default-features --features "rustls-tls-webpki-roots"
-          - os: ubuntu-20.04
+          - os: ubuntu-latest
             platform: android
             dylib: liblivekit_ffi.so
             jar: libwebrtc.jar
             target: x86_64-linux-android
+            ndk_arch: x86_64-unknown-linux-musl
             name: ffi-android-x86_64
             buildargs: --no-default-features --features "rustls-tls-webpki-roots"
 
@@ -105,10 +116,9 @@ jobs:
         with:
           submodules: true
 
-      - uses: actions-rs/toolchain@v1
-        with:
-          toolchain: stable
-          target: ${{ matrix.target }}
+      - name: Install Rust toolchain.
+        run: |
+          rustup target add ${{ matrix.target }}
 
       - name: Set up QEMU
         if: ${{ matrix.target == 'aarch64-unknown-linux-gnu' }}
@@ -143,7 +153,7 @@ jobs:
             yum install clang -y; \
             yum groupinstall 'Development Tools' -y; \
             clang --version; \
-            yum install openssl-devel libX11-devel mesa-libGL-devel libXext-devel -y; \
+            yum install openssl-devel libX11-devel mesa-libGL-devel libXext-devel libva-devel libdrm-devel -y; \
             curl --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y; \
             cd livekit-ffi && cargo build --release --target ${{ matrix.target }} ${{ matrix.buildargs }}"
 
@@ -154,8 +164,9 @@ jobs:
         if: ${{ matrix.platform == 'android' }}
         run: |
           cd livekit-ffi/
+          ln -sf $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/${{ matrix.ndk_arch }}/{libunwind.so,libc++abi.a} $ANDROID_NDK_ROOT/toolchains/llvm/prebuilt/linux-x86_64/lib/
           cargo install cargo-ndk
-          cargo ndk --bindgen --target ${{ matrix.target }} build --release ${{ matrix.buildargs }}
+          cargo ndk --target ${{ matrix.target }} build --release ${{ matrix.buildargs }}
 
       - name: Copy/Build licenses
         run: |
@@ -169,52 +180,52 @@ jobs:
 
       # zip the files
       - name: Zip artifact (Unix)
-        if: ${{ matrix.os != 'windows-2019' && matrix.platform != 'android'}}
+        if: ${{ matrix.os != 'windows-latest' && matrix.platform != 'android'}}
         run: |
           cp livekit-ffi/include/livekit_ffi.h target/${{ matrix.target }}/release/
           cd target/${{ matrix.target }}/release/
           zip ${{ github.workspace }}/${{ matrix.name }}.zip ${{ matrix.dylib }} livekit_ffi.h LICENSE.md
 
       - name: Zip artifact (Unix for Android)
-        if: ${{ matrix.os != 'windows-2019' && matrix.platform == 'android'}}
+        if: ${{ matrix.os != 'windows-latest' && matrix.platform == 'android'}}
         run: |
           cp livekit-ffi/include/livekit_ffi.h target/${{ matrix.target }}/release/
           cd target/${{ matrix.target }}/release/
           zip ${{ github.workspace }}/${{ matrix.name }}.zip ${{ matrix.dylib }} ${{ matrix.jar }} livekit_ffi.h LICENSE.md
 
       - name: Zip artifact (Windows)
-        if: ${{ matrix.os == 'windows-2019' }}
+        if: ${{ matrix.os == 'windows-latest' }}
         run: |
           cp livekit-ffi/include/livekit_ffi.h target/${{ matrix.target }}/release/
           cd target/${{ matrix.target }}/release/
           Get-ChildItem -Path ${{ matrix.dylib }}, livekit_ffi.h, LICENSE.md | Compress-Archive -DestinationPath ${{ github.workspace }}\${{ matrix.name }}.zip
 
       - name: Upload artifacts
-        uses: actions/upload-artifact@v3
+        uses: actions/upload-artifact@v4
         with:
-          name: ffi-builds
+          name: ffi-builds-${{ matrix.target }}
           path: ${{ matrix.name }}.zip
 
-
   release:
     name: Release to GH (Draft)
     runs-on: ubuntu-latest
     needs: build
     permissions:
       contents: write
-    if: startsWith(github.ref, 'refs/tags/ffi-v')
+    if: startsWith(inputs.tag || github.ref_name, 'rust-sdks/livekit-ffi@')
     env:
       GH_TOKEN: ${{ github.token }}
     steps:
       - uses: actions/checkout@v3
 
       - name: Download artifacts
-        uses: actions/download-artifact@v3
+        uses: actions/download-artifact@v4
         with:
-          name: ffi-builds
+          pattern: ffi-builds-*
+          merge-multiple: true
           path: ${{ github.workspace }}/ffi-builds
 
       - name: Create draft release
         run: |
-          gh release create ${{ github.ref_name }} --draft --title "${{ github.ref_name }}"
-          gh release upload ${{ github.ref_name }} ${{ github.workspace }}/ffi-builds/*
+          gh release create ${{ env.TAG_NAME }} --draft --title "${{ env.TAG_NAME }}"
+          gh release upload ${{ env.TAG_NAME }} ${{ github.workspace }}/ffi-builds/*

.github/workflows/format.yml

@@ -31,6 +31,14 @@ jobs:
           toolchain: nightly-2023-12-30
           components: rustfmt
 
+      - name: Check workspace versions match
+        run: |
+          cargo metadata --format-version=1 --no-deps |
+          jq -e -r '.packages[] | "\(.name) \(.version)"' |
+          sort | xargs -l bash -c \
+          'grep "$0 = { version = \"$1\"" -q Cargo.toml && printf "version %-7s %-27s $0\n" $1 "matches package" || printf "version %-7s is not reflected on package $0\n" "$1" | false';
+          if [ $? -eq 0 ]; then exit 0; else exit 1; fi
+
       - name: Cargo fmt
         run: |
           cargo fmt -- --check

.github/workflows/gen-protocol.yaml

@@ -50,7 +50,7 @@ jobs:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
 
       - name: Install prost generators
-        run: cargo install protoc-gen-prost protoc-gen-prost-serde
+        run: cargo install protoc-gen-prost@0.3.1 protoc-gen-prost-serde@0.3.1
 
       - name: generate python stubs
         run: ./generate_proto.sh