-
Notifications
You must be signed in to change notification settings - Fork 24
SOV-5283: add bos as collateral for borrowing #1130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for sovryn-storybook canceled.
|
✅ Deploy Preview for sovryn-dapp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds BOS (BitcoinOS Token) as collateral for borrowing operations across different lending pools. The main purpose is to enable BOS token to be used as collateral when borrowing DLLR, RUSDT, XUSD, DOC, and RBTC.
Key changes include:
- Adding BOS token configuration to asset definitions for both mainnet and testnet environments
- Updating lending pool configurations to accept BOS as collateral across multiple pools
- Refactoring the open loans fetching logic from GraphQL subgraph to direct smart contract queries using React Query
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/contracts/src/contracts/assets/rskTestnet.ts | Adds BOS token configuration for testnet environment |
| packages/contracts/src/contracts/assets/rsk.ts | Normalizes BOS token address to lowercase for mainnet |
| apps/frontend/src/utils/asset.ts | Adds BOS symbol constant to COMMON_SYMBOLS |
| apps/frontend/src/utils/LendingPoolDictionary.ts | Updates lending pools to accept BOS as collateral |
| apps/frontend/src/constants/infrastructure/bsc.ts | Changes BSC RPC endpoints from WebSocket to HTTP |
| apps/frontend/src/app/5_pages/BorrowPage/components/OpenLoansTable/hooks/useGetOpenLoans.ts | Refactors loan fetching from GraphQL to React Query with direct contract calls |
| .vscode/settings.json | Adds editor formatting and code action settings |
| .vscode/extensions.json | Adds recommended VSCode extensions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
https://sovryn.atlassian.net/browse/SOV-5283