Conversation
Member
trstephen
commented
Apr 1, 2017
trstephen
commented
- Nothing for AutoTX commands
- Nothing for error / aborted TXs
- No opinion about how to return rest of account state (balance, etc). Implementation will depend on how FE wants data.
- Nothing for AutoTX commands - Nothing for error / aborted TXs
trstephen
commented
Apr 1, 2017
|
|
||
| pendingSell.Commit() | ||
|
|
||
| acct.AddSummaryItem("Finished " + cs.Name()) |
Member
Author
There was a problem hiding this comment.
The repetition is bothering me...
trstephen
commented
Apr 1, 2017
| if node != nil { | ||
| s = append(s, node.(summaryItem)) | ||
| } | ||
| }) |
Member
Author
There was a problem hiding this comment.
This is pretty gross (lots of memory allocation!) but I can't find a nice way to shrink slices. I want to only return non-emptysummaryItems...
Member
Author
|
Outstanding implementation points tracked with #25. Merging now to do profiling. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.