-
Notifications
You must be signed in to change notification settings - Fork 26
correct role handling and S3FS bypass #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Noting that S3FS bypass appears to be working fine and I had several tests of all the files downloading correctly and then apparently stochastically one run threw: |
|
Full S3FS bypass is working at this point. |
|
I have this branch running on a dataset now and it works (!), successfully completely bypassing S3FS and using a role. |
bethac07
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, this seems great, and super exciting that it's working! Thank you so much
For future, tiiiiiny nitpick - would be great to not mix in a ton of stylistic changes (like "->' in a PR like this already making big behavior changes, or at least make those an explicit commit, just to a) keep the size and readability of the PR reasonable and b) assuming commits aren't squashed, by having them be an explicit commit, you see that that's why a line was changed ("oh, that was done for stylistic reasons" as opposed to "wait, what does this have to do with role handling?"). For this one, there are a lot of commits, so up to you if you'd like us to squash or not, but just something small for the future.
Congrats on this, it was a huge achievement!
fix variable names
|
Thanks @bethac07 ! |
Correct credential handling to enable AWS IAM role usage.