Skip to content
This repository was archived by the owner on Dec 23, 2024. It is now read-only.

Bringup Xiaomi Mi 9T (davinci) to 20.0 from 17.1#234

Closed
GarciaLnk wants to merge 2 commits intoDivested-Mobile:masterfrom
GarciaLnk:master
Closed

Bringup Xiaomi Mi 9T (davinci) to 20.0 from 17.1#234
GarciaLnk wants to merge 2 commits intoDivested-Mobile:masterfrom
GarciaLnk:master

Conversation

@GarciaLnk
Copy link
Contributor

@GarciaLnk GarciaLnk commented Aug 11, 2023

Builds but it needs testing, let me know before publishing if you decide to merge this.

Previous supported version was 17.1
Superseded by 20.0
#4GB+ (2GB+)
sed -i 's/zramsize=.*/zramsize=50%,max_comp_streams=8/' google/redbull/fstab.hardware google/sunfish/fstab.hardware oneplus/msm8998-common/rootdir/etc/fstab.qcom oneplus/sdm845-common/rootdir/etc/fstab.qcom xiaomi/sm6150-common/rootdir/etc/fstab*.qcom &>/dev/null || true;
sed -i 's/zramsize=.*/zramsize=50%,max_comp_streams=8/' google/redbull/fstab.hardware google/sunfish/fstab.hardware oneplus/msm8998-common/rootdir/etc/fstab.qcom oneplus/sdm845-common/rootdir/etc/fstab.qcom &>/dev/null || true;
sed -i 's/zramsize=.*/zramsize=50%,max_comp_streams=8,zram_backingdev_size=512M/' xiaomi/sm6150-common/rootdir/etc/fstab.zram &>/dev/null || true;
Copy link
Member

@SkewedZeppelin SkewedZeppelin Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why have both zramsize and zram_backingdev_size?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm just respecting the device tree changes, zram_backingdev_size seems to enable zram writeback with a 512M limit.

Alternatively, the sed regex could be changed to keep additional changes and only modify the values of zramsize and max_comp_streams if that's the intent of the patch.

fi;

if enterAndClear "device/xiaomi/davinci"; then
smallerSystem;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure it fits?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The system partition in davinci is 3.5 GiB large, so I don't see why the system image would need further reduction. I have used DivestOS in davinci in the past up to 19.1, without using smallerSystem, and I haven't faced any issues.

@SkewedZeppelin SkewedZeppelin added the enhancement New feature or request label Aug 11, 2023
@SkewedZeppelin
Copy link
Member

Thank you for this, I'll merge this after I get the August ASB out for 20.0 after Lineage merges it.

@SkewedZeppelin
Copy link
Member

SkewedZeppelin commented Aug 25, 2023

Merged, thanks!

A davinci 20.0 build should be up on the server in a few minutes.

edit: it is up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Development

Successfully merging this pull request may close these issues.

2 participants