ci: pin golangci-lint version for reproducibility#1
Open
DojoGenesis wants to merge 2 commits into
Open
Conversation
Pins golangci-lint binary to v2.1.6 instead of `version: latest` to prevent silent CI breakage when GitHub's runner-cached "latest" bumps. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
DojoGenesis
force-pushed
the
ci/pin-golangci-lint
branch
from
d990194 to
1d817e0
Compare
Owner
Author
|
Bumped golangci-lint-action v2.1.6 → v2.11.4 to fix Go 1.25.6 build failure (prior version built against Go 1.24 only). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golangci-lintbinary fromversion: latesttoversion: v2.1.6in.github/workflows/ci.ymlversion: latestresolves to whatever GitHub's runner happens to cache — when that bumps, green CI turns red with no code changeSA5011findings the pinned-latest CI doesn't see; this closes that drift windowDrift incident reference
This sweep was triggered by the plugins+gateway remediation run (DojoGenesis/gateway commits 07cb863, ac29ba8, 981e081) where
SA5011nil-pointer dereference findings appeared locally but not in CI — exactly the failure mode that unpinnedlatestallows.Note on action version
This repo uses
golangci/golangci-lint-action@v6(one major behind the current@v7). Theversion:pin is the critical fix; the action major version upgrade is a separate, optional step.Test plan
v2.1.6binary on next pushcontinue-on-error: truemeans failures are non-blocking, but should still be clean)🤖 Generated with Claude Code