-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Description
To Reproduce
This is an issue after #2883, so the initial reproduction steps are described there. Essentially:
- Create an S3 destination with a space in the region, like "European Union"
- Test the connection (now passes because of a fix to the linked issue, very nice 🙏)
- Configure a volume backup and wait for it to be executed
Current vs. Expected behavior
Currently, if stopping the service is selected, the service is stopped, the backup fails, and the service is not restarted. In docker logs I found the following:
Backup error: [Error [ExecError]: Command execution failed: Command failed: rclone copyto --s3-provider=Other --s3-access-key-id=[my-key] --s3-secret-access-key=[my-secret] --s3-region=European Union --s3-endpoint=https://eu2.contabostorage.com --s3-no-check-bucket --s3-force-path-style "/tmp/dokploy-backup-XXXXXXfEzy59/webserver-backup-2025-12-02T05-00-00-327Z.zip" ":s3:nordicstream-backups/dokploy/webserver-backup-2025-12-02T05-00-00-327Z.zip"
I'd expect two things to happen:
- The parameters to be quoted and the backup to happen normally
- Even if it does fail, the service should restart (or maybe if this is expected behavior, it could be an option in the backup config instead? Like "restart service on backup failure".)
Provide environment information
Debian 12
Dokploy v0.25.11Which area(s) are affected? (Select all that apply)
Application
Are you deploying the applications where Dokploy is installed or on a remote server?
Same server where Dokploy is installed
Additional context
No response
Will you send a PR to fix it?
No