docs: restructure database update endpoints documentation#4014
docs: restructure database update endpoints documentation#4014dosubot[bot] wants to merge 1 commit intocanaryfrom
Conversation
|
|
||
| Optional configuration for customizing Docker daemon connections: | ||
|
|
||
| - **DOCKER_API_VERSION** (optional) - Specifies which Docker API version to use when connecting to the Docker daemon. If not set, the Docker client uses the default API version. |
There was a problem hiding this comment.
Incorrect environment variable name
The documented variable name DOCKER_API_VERSION does not match the actual implementation. In packages/server/src/constants/index.ts, the variable is DOKPLOY_DOCKER_API_VERSION:
export const DOKPLOY_DOCKER_API_VERSION =
process.env.DOKPLOY_DOCKER_API_VERSION;Users following this documentation would set the wrong environment variable and it would have no effect.
| - **DOCKER_API_VERSION** (optional) - Specifies which Docker API version to use when connecting to the Docker daemon. If not set, the Docker client uses the default API version. | |
| - **DOKPLOY_DOCKER_API_VERSION** (optional) - Specifies which Docker API version to use when connecting to the Docker daemon. If not set, the Docker client uses the default API version. |
| - **INNGEST_EVENTS_RECEIVED_AFTER** (optional) - An RFC3339 timestamp to filter events received after a specific date (e.g., `2024-01-01T00:00:00Z`). If unset, no date filter is applied. | ||
|
|
||
| - **INNGEST_JOBS_MAX_EVENTS** (optional) - Maximum number of events to fetch when listing jobs. Default is 100, maximum is 10000. Used for pagination with cursor. |
There was a problem hiding this comment.
Documented env vars not implemented in code
INNGEST_EVENTS_RECEIVED_AFTER and INNGEST_JOBS_MAX_EVENTS are documented as functional environment variables, but they are not actually read or used in apps/api/src/service.ts. The implementation hardcodes DEFAULT_MAX_EVENTS = 500 and never references either of these env vars.
Additionally, the documented default for INNGEST_JOBS_MAX_EVENTS ("Default is 100") contradicts the hardcoded value of 500 in the code.
This could confuse users who try to configure these variables expecting them to have an effect. Consider either implementing support for these variables or removing them from the documentation.
Update documentation for #4013
Reorganized the Database Service Update Endpoints section for improved clarity and usability. The documentation now clearly outlines that all five database services (PostgreSQL, MySQL, MariaDB, MongoDB, Redis) share a common update interface with the
dockerImageparameter, providing users with better guidance on custom Docker image configuration and version pinning options.Generated by Dosu
Greptile Summary
This PR adds extensive API documentation to
apps/api/README.md, covering environment variables, API endpoints (jobs, search, database updates), and whitelabeling endpoints. While the PR title says "restructure database update endpoints documentation," the actual scope is much broader — it's effectively a full API reference for theapps/apiservice.dockerImageparameter documentation for database update endpoints is accurate and matches the schemas inpackages/server/src/db/schema/DOCKER_API_VERSIONin the docs should beDOKPLOY_DOCKER_API_VERSIONto match the implementation inpackages/server/src/constants/index.tsINNGEST_EVENTS_RECEIVED_AFTERandINNGEST_JOBS_MAX_EVENTSare documented as configurable but are not actually used in the service code; the max events value is hardcoded to 500 (not 100 as documented)Confidence Score: 3/5
apps/api/README.md— environment variable names and defaults should be verified against the actual implementation before merging.Last reviewed commit: d287e2a