Open
Conversation
ghost
reviewed
Aug 10, 2020
| public class Calculator { | ||
|
|
||
| public static int sumOfNaturalNumbers(int limit) { | ||
| return Stream.iterate(1, n -> n < limit, n -> n + 1) |
There was a problem hiding this comment.
Alternatywnie możesz tutaj użyć IntStream.range()
| } | ||
|
|
||
| public static int fibonacciSequence(int limit) { | ||
| return Stream.iterate(new int[]{1, 1}, n -> new int[]{n[1], n[0] + n[1]}) |
There was a problem hiding this comment.
Liczby fibonacciego jest to jedna z rzeczy które lepiej wyglądają jak są zaimplementowane na for while niż na streamach :)
| return Stream.iterate(new int[]{1, 1}, n -> new int[]{n[1], n[0] + n[1]}) | ||
| .limit(limit) | ||
| .map(n -> n[0]) | ||
| .filter(n -> (n % 2 == 0)) |
| .limit(limit) | ||
| .map(n -> n[0]) | ||
| .filter(n -> (n % 2 == 0)) | ||
| .mapToInt(n -> n) |
There was a problem hiding this comment.
Taka funkcja nazywa się identity i można jej implementację znaleźć w Function.identity()
| import static homeWork_20.Calculator.fibonacciSequence; | ||
|
|
||
| public class SumOfEvenFibonacciNumbersTest { | ||
|
|
|
|
||
| //then | ||
| int expectedNumber = 10; | ||
| Assertions.assertThat(sumOfEvenNumbers).isEqualTo(expectedNumber); |
There was a problem hiding this comment.
Stosuj statyczne importy - dodają czytelności testom
| import static homeWork_20.Calculator.*; | ||
|
|
||
| public class SumOfMutlipliers5or3Test { | ||
|
|
| Assertions.assertThat(sumOfMultipliers).isEqualTo(expectedNumber); | ||
| } | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.