Show symbol type on hover#657
Merged
DonJayamanne merged 1 commit intoDonJayamanne:masterfrom Jan 23, 2017
patrys:symbol-type-on-hover
Merged
Show symbol type on hover#657DonJayamanne merged 1 commit intoDonJayamanne:masterfrom patrys:symbol-type-on-hover
DonJayamanne merged 1 commit intoDonJayamanne:masterfrom
patrys:symbol-type-on-hover
Conversation
Contributor
Author
|
I think this is ready for review now. The behaviour is as follows:
|
Contributor
|
Any screenshots? |
Contributor
Author
Contributor
|
Looks great. Anything you can do to handle very long doc strings, like limiting the hover box height and adding a scroll bar, or is that limited by VS Code? |
Contributor
Author
|
This is already handled by VS Code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


I'm playing with the idea of providing type annotations on hover instead of duplicating autocomplete results. This is quite useful especially when combined with PEP 484 annotations or comments with type hints.