Graphic Designers Summit

[Donmark2k]

Highlights 🥇

HTML/CSS & JavaScript capstone project - Conference page

Learning objectives

• Use semantic HTML tags.
• Apply best practices in HTML code.
• Use CSS selectors correctly.
• Use CSS box model.
• Use Flexbox to place elements in the page.
• Demonstrate ability to create website adaptable to different screen sizes using media queries.
• Use GitHub Pages to deploy web pages.
• Apply JavaScript best practices and language style guides in code.
• Use JavaScript to manipulate DOM elements.
• Use JavaScript events.
• Use objects to store and access data.
• Communicate technical concepts to other technical people.

What I Have Done:

• Added linters. The JavaScript + HTML + CSS linter.
• I designed it such that the home page have a link in the menu to the about page.
• The logo in the header links to the home page.
• When the user clicks (or taps) the hamburger button on the header, the mobile menu appears over the page.
• When the user click on (X) button, it closes the mobile menu.
• "Featured speakers" was created dynamically in JavaScript.

Followed Rules:

• Made sure no linter errors
• Followed Github Flow
• Documented professionaly
• Followed the list of best practices for HTML & CSS.
• Followed our list of best practices for JavaScript.

[HAMMAS-SALEEM]

Required Changes ♻️

Hey @Donmark2k 👋

Highlights 🥇

✔️ Descriptive PR Title
✔️ Descriptive PR Summary
✔️ Following Gitflow
✔️ Following some requirements

Good job on implementing some of the requirements, there are some issues that you still need to work on to go to the next project but you are almost there! 😊

Optional

All the changes with optional tags are not crucial enough to prevent you from getting the approval but we highly recommend to students that they should take these changes into consideration.

Cheers and Happy coding! 👏 👏 👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear. Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[danmainah]

Hi @Donmark2k ,

Great work on making the changes requested by a previous reviewer 👏 👏 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

✔️ No linter errors
✔️ Github flow was correctly used
✔️ Good design

Required Changes ♻️

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

[brainconnect93]

Status: Approved ✔️

Hi @Donmark2k, 👋 👋

Your project is complete! Great job for following the project requirement🥇and implementing the changes requested by the previous reviewer. There is nothing else to say other than... it's time to merge it 🍾🚢 . Congratulations! 🎉💯🌟

Good Points 👍

• Has a proper Pull Request. ✔️
• No Linter errors ✔️
• Good use of Github flow ✔️

Optional changes

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me @brainconnect93 in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.

---

As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.

[Donmark2k]

Thanks @brainconnect93 for the wonderful review and approval