fix: Seerr login browser cookie handling on container deployment#826
Merged
PartyDonut merged 5 commits intoDonutWare:developfrom Mar 10, 2026
Merged
fix: Seerr login browser cookie handling on container deployment#826PartyDonut merged 5 commits intoDonutWare:developfrom
PartyDonut merged 5 commits intoDonutWare:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Seerr connection fails on container deploymenth with No session cookie returned by server.
Browsers process the
set-cookieresponse header internally but never expose it to JavaScript. Fladder can't capture the session cookie and treats login as failed. Much better described by @Wunderharke: Jellyseerr local login fails from web (proxmox helper script); works fine from android #710 (comment)This fix uses a conditional-import
BrowserClientwithwithCredentials: trueso the browser manages session cookies on its own. Since Fladder can't see whether a cookie was set, a__browser_managed__sentinel is stored on web instead,and
_authHeadersskips the manual Cookie header since the browser should already attach it.This feature was part of PR feat: Seerr QC login, password-login hide, auto-URL scheme, new ENV vars | fix: Set-Cookie #812
NOTE: Cross-origin setups still require CORS headers on the Seerr side
Testing Build
Issue Being Fixed
Screenshots / Recordings
N/A
Notes
AI Disclosure
Developed with assistance from Claude Code (Opus 4.6). The AI helped me identify the related files, code parts and proposed possible code modifications and fixes.
I've manually reviewed, cleaned, refactored and hardened the code the best I could, but since my Dart capabilities are not that good, I see this PR more as a proposal/idea.
A Proper code review is required in any case...
Checklist