Skip to content

chore: Remove seerrHeader from config.json#833

Merged
PartyDonut merged 1 commit intodevelopfrom
fix/remove-header-from-config.json
Mar 10, 2026
Merged

chore: Remove seerrHeader from config.json#833
PartyDonut merged 1 commit intodevelopfrom
fix/remove-header-from-config.json

Conversation

@PartyDonut
Copy link
Copy Markdown
Collaborator

Pull Request Description

Remove seerrHeaders from config.json

@PartyDonut PartyDonut merged commit 5fdafa4 into develop Mar 10, 2026
1 check passed
@PartyDonut PartyDonut deleted the fix/remove-header-from-config.json branch March 10, 2026 18:36
@v3DJG6GL
Copy link
Copy Markdown
Contributor

v3DJG6GL commented Mar 22, 2026

@PartyDonut
I've seen you reverted Seerr header implementation through ENV value.

I did a new look at it and implemented it with a different approach (similar as I did it once before):
develop...v3DJG6GL:Fladder:feat/seerr-custom-headers
AFAIK, that should not reveal configured header values to end users.

@PartyDonut
Copy link
Copy Markdown
Collaborator Author

@PartyDonut I've seen you reverted Seerr header implementation through ENV value.

I did a new look at it and implemented it with a different approach (similar as I did it once before): develop...v3DJG6GL:Fladder:feat/seerr-custom-headers AFAIK, that should not reveal configured header values to end users.

Have not tested it. But the browser would still leak it when the api call is made right? If not then by all means a PR would be great 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants