Skip to content

fix: video playback state synchronization #960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
schembriaiden wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix: video playback state synchronization #960

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/providers/video_player_provider.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ class VideoPlayerNotifier extends StateNotifier<MediaControlsWrapper> {
mediaState.update(
(state) => state.copyWith(playing: event),
);
ref.read(playBackModel)?.updatePlaybackPosition(currentState.position, currentState.playing, ref);
ref.read(playBackModel)?.updatePlaybackPosition(currentState.position, event, ref);
}

Future<void> updatePosition(Duration event) async {
Expand Down
11 changes: 11 additions & 0 deletions lib/screens/video_player/video_player.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,10 +59,21 @@ class _VideoPlayerState extends ConsumerState<VideoPlayer> with WidgetsBindingOb
super.dispose();
}

void _setupListeners() {
ref.listenManual(
mediaPlaybackProvider.select((value) => value.playing),
(previous, next) {
playing = next;
},
fireImmediately: true,
);
}

@override
void initState() {
super.initState();
WidgetsBinding.instance.addObserver(this);
_setupListeners();
Future.microtask(() {
ref.read(mediaPlaybackProvider.notifier).update((state) => state.copyWith(state: VideoPlayerState.fullScreen));
final orientations = ref.read(videoPlayerSettingsProvider.select((value) => value.allowedOrientations));
Expand Down
Loading