feat: Chapter image trickplay/timeline fallback#963
Draft
matt-hb wants to merge 8 commits intoDonutWare:developfrom
Draft
feat: Chapter image trickplay/timeline fallback#963matt-hb wants to merge 8 commits intoDonutWare:developfrom
matt-hb wants to merge 8 commits intoDonutWare:developfrom
Conversation
TODO: Chapter Timeline widget
Contributor
Author
|
looks like some old commits from another PR are still there, they don't do anything for the diff though, my bad! |
Collaborator
|
Just did a test for Android TV it's quite blurry. Does not look great to be honest. Another solution would be to change the filterquality inside of the 
|
Contributor
Author
Good call, I misunderstood low level drawing and size inheriting before, but after checking this is in fact a lot better. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
First actual feature PR, chapter images have been bothering me a bunch so I'm implementing a trickplay fallback as per #875 .
Would love if someone could try it out on bigger screens on Android TV to see how it looks, since currently I am blurring trickplay images a bit as they are lower resolution (I think a bit of blur is nicer than pixelation).
Also added caching for trickplay images, because we're fetching them a bunch.
Issue Being Fixed
Placeholder when there are no chapter images available, either via fallback to trickplay images or a timeline if trickplay images are not available either.
Screenshots / Recordings
Before (yucky placeholders):
After (with trickplay fallback):
After (with timeline):
TODO
Tested On
Checklist