fix: Failed to play items with empty backdrop image list#969
Merged
PartyDonut merged 1 commit intoDonutWare:developfrom Apr 28, 2026
Merged
fix: Failed to play items with empty backdrop image list#969PartyDonut merged 1 commit intoDonutWare:developfrom
PartyDonut merged 1 commit intoDonutWare:developfrom
Conversation
ImagesData.firstOrNull accessed backDrop[0] directly, throwing a RangeError when the list existed but was empty. Use List.firstOrNull instead to safely return null, fixing video playback on all platforms.
PartyDonut
reviewed
Apr 28, 2026
|
|
||
| ImageData? get firstOrNull { | ||
| return primary ?? backDrop?[0]; | ||
| return primary ?? backDrop?.firstOrNull; |
Collaborator
There was a problem hiding this comment.
I feel deep shame for making this mistake 😰.
Thanks for fixing it.
PartyDonut
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ImagesData.firstOrNull accessed backDrop[0] directly, throwing a RangeError when the list existed but was empty. Use List.firstOrNull instead to safely return null, fixing video playback with this specific circumstance.
Issue Being Fixed
I had an issue when playing a video in Linux and on iOS. The player would not load, it was stuck in "Loading" while the audio was playing in the background.
Tested On
Checklist