feat: add HIDE_PASSWORD_LOGIN ENV var & client setting to hide password fields on login#973
Open
v3DJG6GL wants to merge 15 commits intoDonutWare:developfrom
Open
feat: add HIDE_PASSWORD_LOGIN ENV var & client setting to hide password fields on login#973v3DJG6GL wants to merge 15 commits intoDonutWare:developfrom
v3DJG6GL wants to merge 15 commits intoDonutWare:developfrom
Conversation
…PASSWORD_LOGIN combos
…DE_PASSWORD_LOGIN is also set
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Description
HIDE_PASSWORD_LOGINContainer ENV var and a matching client-side setting to hide the username/password fields on the login screen, leaving only Jellyfin QuickConnect as the login path.Features
UI / UX
hidePasswordLoginis set.HIDE_PASSWORD_LOGINhas been enabled with ENV var.BASE_URLandHIDE_PASSWORD_LOGINare set, the URL, password and Login fields are all hidden. The back, refresh, and "advanced login options" buttons consolidate into a single centered row above the Quick Connect button.HIDE_PASSWORD_LOGINis set (noBASE_URL), the existing URL-entry top row is preserved and the advanced login options button keeps its standalone centered row as before.Container: New ENV
HIDE_PASSWORD_LOGIN: Set to"true"to hide password login fields and show only QuickConnect on the login screen.truedisables this feature.config.jsonashidePasswordLogin: true | null.Refactor
IconButton.filledTonalinlogin_screen_credentials.dartinto a localadvancedOptionsButtonwidget (the button was rendered in two conditional branches with identical callbacks).backButton/refreshButtonlocals and consolidated them withadvancedOptionsButtoninto a single centered row when the URL field is hidden — replaces the left-pinned top row and centered row with one clean strip.Issue Being Fixed
N/A
Screenshots
Login Screen (with
SEERR_URL&BASE_URLset &HIDE_PASSWORD_LOGINset totrue)Settings: Hide Password login toggle (disable since ENV
HIDE_PASSWORD_LOGINis set totrue)Notes
AI Disclosure
Developed with assistance from Claude Code (Opus 4.7). The LLM helped me identify the related files, code parts and proposed possible code modifications and fixes.
I've manually reviewed, cleaned, refactored and hardened the code the best I could.
Tested On
Checklist