suggested fixes by iCR, OpenRefactory, Inc. #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OpenRefactory introduces fixers, that automatically fix safety, security, reliability and compliance issues. We ran OpenRefactory's Intelligent Code Repair (iCR) analysis engine on your code. We are reporting a few sample fixes that were generated.
The goal of the this fix is to resolve Improper Method Call, Zero Division Check and Weak Library Usage.
Improper Method Call Fix:
In file:
RemoteControlServer.java, class:RCServerThread, method:finalizeoverrides the method defined in its superclass. But the implementation does not refer to the overridden method . iCR suggested changes in 1 files to resolve the problem.In file:
DefinitionsDocument.java, class:DefinitionsDocument, method:finalizeoverrides the method defined in its superclass. But the implementation does not refer to the overridden method . iCR suggested changes in 1 files to resolve the problem.The fix addresses CWE 568.
Zero Division Check Fix:
In file:
ExpressionEvaluator.java, class:ExpressionEvaluator, method:value, there are potential Division By Zero errors while running. iCR suggested changes in 1 files to resolve the problem.The fix addresses CWE 369.
Weak Library Usage Fix:
In file:
LogTest.java, class:LogTest, method:testConcurrentWritesuses Random object but it may not be truly random. It should be replaced with SecureRandom. . iCR suggested changes in 1 files to resolve the problem.