Merged
Conversation
…rogress spinner handling
ArielSantos01
approved these changes
Feb 25, 2026
danteay
approved these changes
Feb 25, 2026
Collaborator
danteay
left a comment
There was a problem hiding this comment.
LGTM. Clean and well-scoped change.
What was reviewed:
- Refactoring of
executeConcurrentWithProgressto decouple progress reporting from work logic via therunWork(onProgress)callback pattern. - TTY vs non-TTY branching: spinner for interactive terminals, plain log output for CI.
- The
isTTY()helper correctly delegates todata.Flags.TTY, which defaults totruein the CLI root command.
Positives:
- The callback-based approach (
onProgress func(string)) is clean and avoids code duplication between TTY and non-TTY paths. - Redundant comments were removed, improving readability.
- Change is backward-compatible (TTY defaults to true).
Minor note (non-blocking):
- No new tests for the TTY branching, but given the trivial nature of
isTTY()and that the core work logic is shared, this is acceptable.
All CI checks pass. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Se agrega la opción de no TTY para CI