Skip to content

feat: no TTY option for mockery#194

Merged
negarciacamilo merged 1 commit intomainfrom
chore/no-tty
Feb 25, 2026
Merged

feat: no TTY option for mockery#194
negarciacamilo merged 1 commit intomainfrom
chore/no-tty

Conversation

@negarciacamilo
Copy link
Contributor

Description

Se agrega la opción de no TTY para CI

@negarciacamilo negarciacamilo merged commit 3e4297b into main Feb 25, 2026
2 checks passed
@negarciacamilo negarciacamilo deleted the chore/no-tty branch February 25, 2026 14:35
Copy link
Collaborator

@danteay danteay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Clean and well-scoped change.

What was reviewed:

  • Refactoring of executeConcurrentWithProgress to decouple progress reporting from work logic via the runWork(onProgress) callback pattern.
  • TTY vs non-TTY branching: spinner for interactive terminals, plain log output for CI.
  • The isTTY() helper correctly delegates to data.Flags.TTY, which defaults to true in the CLI root command.

Positives:

  • The callback-based approach (onProgress func(string)) is clean and avoids code duplication between TTY and non-TTY paths.
  • Redundant comments were removed, improving readability.
  • Change is backward-compatible (TTY defaults to true).

Minor note (non-blocking):

  • No new tests for the TTY branching, but given the trivial nature of isTTY() and that the core work logic is shared, this is acceptable.

All CI checks pass. Approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants