Allocations reduction#153
Merged
Merged
Conversation
They are buffers for which user can ask for a page count. The first page is always allocated. When the user needs the buffer size to change, he can call crg::Buffer::resize. If the requested size is higher than the allocated size, new pages are created. In the shader, the buffer must be declared as a buffer array with maxPages as dimension. The allocated pages will be bound, and the remaining pages will be filled with dummy buffer.
It allows rebuilding the descriptor set when the pass bindings change.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 73 73
Lines 6017 6368 +351
==========================================
+ Hits 6017 6368 +351
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
DragonJoker
force-pushed
the
allocations_reduction
branch
from
60b2e8a to
a38bc57
Compare
DragonJoker
force-pushed
the
allocations_reduction
branch
from
a38bc57 to
2891fef
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.