feat(procfs): improve standard /proc entries and add /proc/uptime#1807
Open
jiuyue486 wants to merge 1 commit intoDragonOS-Community:masterfrom
Open
feat(procfs): improve standard /proc entries and add /proc/uptime#1807jiuyue486 wants to merge 1 commit intoDragonOS-Community:masterfrom
jiuyue486 wants to merge 1 commit intoDragonOS-Community:masterfrom
Conversation
fslongjin
requested changes
Mar 9, 2026
Comment on lines
+146
to
+149
|
|
||
| s.push_str("DragonOS Process Status\n"); | ||
| s.push_str("=======================\n"); | ||
|
|
Member
|
@claude review |
|
Claude finished @fslongjin's task in 5m 51s —— View job PR Review for #1807: feat(procfs): improve standard /proc entries and add /proc/uptimeI'll review the PR changes and provide feedback. Here's my plan:
Review Summary The existing review comment is correct: line 149 in Key Findings:
Recommendations:
Next Steps: Would you like me to implement specific fixes for the status file? I can:
The choice depends on how closely you want to match Linux behavior versus maintaining DragonOS-specific extensions. |
Author
|
收到
我修改好之后再交一次pr可以吗,龙学长
王鹏
---- Replied Message ----
| From | ***@***.***> |
| Date | 03/09/2026 10:42 |
| To | ***@***.***> |
| Cc | ***@***.***>***@***.***> |
| Subject | Re: [DragonOS-Community/DragonOS] feat(procfs): improve standard /proc entries and add /proc/uptime (PR #1807) |
@fslongjin requested changes on this pull request.
In kernel/src/filesystem/procfs/pid/status.rs:
+
+ s.push_str("DragonOS Process Status\n");
+ s.push_str("=======================\n");
+
这个行为与Linux不一致。
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Member
|
Author
|
收到 学长 今天上完课我就回去再修改一下
…---- 回复的原邮件 ----
| 发件人 | ***@***.***> |
| 日期 | 2026年03月09日 10:51 |
| 收件人 | ***@***.***> |
| 抄送至 | ***@***.***>***@***.***> |
| 主题 | Re: [DragonOS-Community/DragonOS] feat(procfs): improve standard /proc entries and add /proc/uptime (PR #1807) |
fslongjin left a comment (DragonOS-Community/DragonOS#1807)
需要对照Linux 6.6.21的代码来做
本地下好上述linux代码,让ai参考这个的行为来review
每个pr功能应该单一,而不是一次改一堆东西
新增的功能应当在dunitest下面补充单元测试
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR improves several standard procfs entries in DragonOS.
Changes included:
Validation:
Closes #1751