Skip to content

Conversation

@Kirrus-Indiestone
Copy link

This patch adds a configuration option which will let end users arbitrarily override the role displayed to end users from the config option
overrideRoleNameDisplay

This allows to hide a moderator with a hitched role which is unsuitable to be displayed to end users. In our case, specifically a hidden moderator with a general user role. Not able to use fallbackRoleName, because the hidden moderator has a hitched role.

I have not coded in a very long time, and never in JS before, so rusty doesn't even begin to cover it. Thoughts/rejection/comments/patches appreciated :)

I've tested this patch on our server, and it appears to work okay, but have not tested all existing functions exhaustively

@Kirrus-Indiestone Kirrus-Indiestone marked this pull request as draft October 31, 2023 20:05
@Kirrus-Indiestone
Copy link
Author

TODO:

  • Verify fallback works when override not in effect
  • Document option in configuration.md

@Kirrus-Indiestone
Copy link
Author

Fallback still works whilst override not enabled, configuration option documented

@Kirrus-Indiestone Kirrus-Indiestone marked this pull request as ready for review November 1, 2023 12:02
@Dragory Dragory merged commit 47a4fa9 into Dragory:master Oct 14, 2024
@Dragory
Copy link
Owner

Dragory commented Oct 14, 2024

This looks good, thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants