Fix PiglinBruteBrainMixin concerns [1.18.2]#489
Merged
Draylar merged 1 commit intoDraylar:arch-1.18.2from Feb 17, 2023
Merged
Conversation
dhyces
changed the title
Author
|
Should be able to be merged into updated branches as well |
|
You talking aboult how piglins go all wako even if ur an hostile identity |
Author
No idea what you're referring to. I haven't played with this mod other than the testing I did to ensure this worked. This is purely a functional change that does not impact how the identities work. It does however ensure safety between mods to keep compatibility. |
|
Was this fix ever implemented? I'm still getting this crash on 1.19.2 when using Identity alongside the Bygone Nether mod |
Owner
|
Thank you dhyces, much appreciated! I'm pushing this out in version 2.3.1 now. |
Owner
|
3ca027e for 1.19.1 patch, version 2.6.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #488
The mixin before was using an Overwrite which causes concerns for other mods wanting to influence the behavior of the method (known as getTargetIfWithinRange on mojmaps). We now inject directly into the backing method of the filter lambda seen in the original method. This also fixes safety of other developers aiming to AW/AT the method to public in their own mods, as overwrite disallows this.
Tested it in production of both fabric and forge environments.
See edited javadoc for more info on the change implementation.