Is there some particular reason why my PR that adds v3 (shopper activity) end point support has never been merged?

[RickKukiela]

#40

I added this PR over two years ago. I have been using my fork in production since then. The new endpoint code works flawlessly.

Is there some reason you refuse to support the shopper activity endpoints here when it's clearly capable of doing so?

[BenSandeen]

Sorry, we must've missed your PR! We'll take a look at it and, if things look good, we'll go ahead and merge it. Thanks for helping to make our product better!

[BenSandeen]

Okay, I've just merged it; thanks again for contributing!

[RickKukiela]

Awesome news! Thanks! I'm happy I can switch my code to use the main branch again so I get all the other updates now :)

[RickKukiela]

@BenSandeen Would it be possible for there to be a new version/tag for the new feature? Might be 1.5.0 since it adds new features? Its not backwards breaking though so I supposed 1.4.3 would work too- I'm on not the best source on what version number / scheme to use, when and why though hahaha...

EDIT: According to https://semver.org/ - I believe it should be 1.5.0

MAJOR version when you make incompatible API changes
MINOR version when you add functionality in a backward compatible manner
PATCH version when you make backward compatible bug fixes

[BenSandeen]

Ah, good call, I'll take a look at that, thanks!

[BenSandeen]

Do you need a tagged version, or is updating the version in the code sufficient?

[BenSandeen]

Okay, nevermind, I updated the version in code and created a new tag, and then because Github didn't seem to include my changes that updated the version number in code, I created a version 1.5.1 tag and release; hopefully that'll get you where you need to be!

[RickKukiela]

@BenSandeen - Yes, thank you! The new version is showing up on packagist so following the standard install process for this would result in the new code being installed (provided there were not version constraints on the project limiting it to an older version).

[BenSandeen]

Woo, perfect, thanks for confirming!