Skip to content

Conversation

@BenSandeen
Copy link

@BenSandeen BenSandeen commented Aug 17, 2022

WIP

Addresses: #80

Background

Our API doesn't store data properly as a JSON object; rather, it's a Ruby hash

Modification

Store objects as JSON

Result

API should store objects in a usable way

Additional Context

N/A

How to verify/test

I'm not sure yet, as I've never worked with this repo before. Please advise

@BenSandeen BenSandeen self-assigned this Aug 17, 2022
@BenSandeen BenSandeen requested a review from a team August 17, 2022 20:10
@BenSandeen
Copy link
Author

BenSandeen commented Aug 17, 2022

ECI people, please let me know how to run the tests. I've never touched this code, so I have no idea if my changes will break things

@will-in-wi
Copy link
Contributor

I think bundle exec rake test will do it.

@iantance
Copy link
Contributor

I'm not sure this needs fixing. I don't know exactly what they are trying to do, but I believe items is an array of objects intentionally. Those ruby objects get passed to the liquid context and should be accessible there.

@BenSandeen
Copy link
Author

Interesting.... Should I close this? And can someone respond to the person who filed the issue?

@iantance
Copy link
Contributor

I'll respond on the issue to see if we can find out more about what they are trying to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants