feat: user invite uses external domain option#118
Merged
DecDuck merged 3 commits intoDrop-OSS:developfrom Jun 30, 2025
Merged
Conversation
Member
|
Does system config do any sort of normalisation on the external URL? I feel like when appending it like this we should have a guarantee that it's a fully URL or whatever. |
Contributor
Author
|
Not currently, I was thinking about it but didn't feel like adding a bunch of code to normalize the url |
Member
|
Should probably throw a package at it rather than maintain our own logic: https://www.npmjs.com/package/normalize-url or similar |
Contributor
Author
|
I was just hoping that by throwing an error at the user via the console they would sorta get it, but that probably is a better idea yea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #117