#51 Adds settings page with showTitleDescriptionOnGamePanel#124
Closed
Pacodastre wants to merge 7 commits intoDrop-OSS:developfrom
Closed
#51 Adds settings page with showTitleDescriptionOnGamePanel#124Pacodastre wants to merge 7 commits intoDrop-OSS:developfrom
Pacodastre wants to merge 7 commits intoDrop-OSS:developfrom
Conversation
Member
|
I think you're missing some files or commits, because I can't find A couple of notes:
I'll do a full line-by-line review after |
Contributor
Author
I'm not sure why I'm getting the eslint errors. The keys that it's complaining about are being used on the settings page. |
Member
|
See #130 Sorry for not using this PR, I hate GitHub. Edit: you should still get credit for the commits as the author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the showTitleDescriptionOnGamePanel setting.
isHiddenflag on the Game schema. I then added a filter in all game queries to exclude the hidden games (i.e the dummy game). The hidden image is only used for dummy data.