This repository was archived by the owner on Feb 11, 2025. It is now read-only.
Update JsonWebKeySet with RawData property #463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Consumers may want to access the raw JSON string that was used to deserialize the JsonWebKeySet object to use with other libraries such as Microsoft.IdentityModel.Tokens.JsonWebKeySet. This avoids having to serialize the object again to get the JSON string.
ariveron
commented
Aug 1, 2022
| /// The JSON string used to deserialize this object | ||
| /// </summary> | ||
| [JsonIgnore] | ||
| public string RawData { get; set; }; |
Contributor
Author
There was a problem hiding this comment.
I wasn't entirely sure what an appropriate name for this property should be. Thinking about it again, maybe I should have suggested to use Raw instead of RawData, in keeping with the precedent set by the ProtocolResponse class. And maybe the set should be protected or private?
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumers may want to access the raw JSON string that was used to deserialize the
JsonWebKeySetobject to use with other packages such asMicrosoft.IdentityModel.Tokens.JsonWebKeySet. This avoids having to serialize the object again, or making a second REST call to the identity server to get the JSON string.