Modular functions, support grouping chains, and partial support for Chai-1 models#22
Open
y1zhou wants to merge 44 commits intoDunbrackLab:mainfrom
Open
Modular functions, support grouping chains, and partial support for Chai-1 models#22y1zhou wants to merge 44 commits intoDunbrackLab:mainfrom
y1zhou wants to merge 44 commits intoDunbrackLab:mainfrom
Conversation
…n pDockQ calculations
…in the .pml output The content are the same, but the original script outputs the coloring of the last asym pair *after* the max comment row. The original script also outputs extra whitespace around chain ID selection.
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…class Refactor summary_lines to ChainPairScoreResults dataclass
…ied chain groups Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…tion Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…s token, -g flag Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…ming, and byres ordering Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…ank line separator Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
…ample files Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Co-authored-by: y1zhou <17245097+y1zhou@users.noreply.github.com>
Add --chain-groups CLI argument for calculating scores between specified chain groups
Author
|
Since commit 1dd0697, two additional things were added:
|
…t alphanumerically
Member
|
Thanks for doing all this. It'll take me some time to go through it. Roland |
Author
|
@dunbrack Thanks for taking the time to review this! I know it's a huge PR so please let me know if anything is unclear and I can work alongside to fix the issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New
.pre-commit-config.yamlto standardize formatting and catch linter errors.Changed
ipsae()function that can be imported by other scripts for downstream processing. Results are stored as lists of dataclasses, which can be trivially transformed to pandas or polars data frames.stdoutand to a specific directory via--output-dir.Fixed
These changes collectively improve the usability, reproducibility, and maintainability of the IPSAE scoring tool.