Conversation
Snyk has created this PR to upgrade eslint from 8.40.0 to 9.36.0. See this package in npm: eslint See this project in Snyk: https://app.snyk.io/org/dustin4444/project/0e3da06b-005f-40e7-b7da-9c61bed2d301?utm_source=github&utm_medium=referral&page=upgrade-pr
|
Important Review skippedIgnore keyword(s) in the title. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @Dustin4444, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request, automatically generated by Snyk, aims to update the project's "eslint" dependency to the latest major version, "9.36.0". This update is crucial for maintaining up-to-date dependencies, incorporating the latest features and bug fixes, and most importantly, addressing a substantial list of security vulnerabilities across various severity levels. Due to the major version bump, thorough testing is recommended to mitigate any potential breaking changes. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request upgrades eslint from v8.40.0 to v9.36.0, which is a major version update that addresses several security vulnerabilities. While applying these security fixes is important, this upgrade introduces breaking changes. Most notably, ESLint v9 uses a new 'flat config' system, which will require a manual migration of your configuration files. Furthermore, the package-lock.json file has not been updated along with package.json. This must be corrected by running npm install and committing the updated lock file to ensure consistent builds and prevent CI failures.
| "@userscripters/storage": "^0.1.2", | ||
| "chai": "^4.3.7", | ||
| "eslint": "^8.39.0", | ||
| "eslint": "^9.36.0", |
There was a problem hiding this comment.
While the eslint version is correctly updated here, the package-lock.json file has not been updated. This will lead to inconsistencies and likely cause CI builds that use npm ci to fail. Please run npm install and commit the updated package-lock.json file.
Additionally, this is a major version upgrade from ESLint v8 to v9, which introduces significant breaking changes. Your project's ESLint configuration will need to be migrated to the new 'flat config' format. You can find instructions in the ESLint v9 migration guide.
2 participants
Snyk has created this PR to upgrade eslint from 8.40.0 to 9.36.0.
ℹ️ Keep your dependencies up-to-date. This makes it easier to fix existing vulnerabilities and to more quickly identify and fix newly disclosed vulnerabilities when they affect your project.
The recommended version is 68 versions ahead of your current version.
The recommended version was released 25 days ago.
Issues fixed by the recommended upgrade:
SNYK-JS-BRACES-6838727
SNYK-JS-BROWSERIFYSIGN-6037026
SNYK-JS-CROSSSPAWN-8303230
SNYK-JS-ELLIPTIC-8172694
SNYK-JS-GETFUNCNAME-5923417
SNYK-JS-NANOID-8492085
SNYK-JS-SERIALIZEJAVASCRIPT-6147607
SNYK-JS-BRACEEXPANSION-9789073
SNYK-JS-BRACEEXPANSION-9789073
SNYK-JS-CIPHERBASE-12084814
SNYK-JS-ELLIPTIC-7577916
SNYK-JS-ELLIPTIC-7577917
SNYK-JS-ELLIPTIC-7577918
SNYK-JS-ELLIPTIC-8720086
SNYK-JS-PBKDF2-10495496
SNYK-JS-PBKDF2-10495498
SNYK-JS-SHAJS-12089400
SNYK-JS-WORDWRAP-3149973
Release notes
Package name: eslint
Features
47afcf6feat: correctpreserve-caught-erroredge cases (#20109) (Francesco Trotta)Bug Fixes
75b74d8fix: add missing rule option types (#20127) (ntnyq)1c0d850fix: updateeslint-all.jsto useObject.freezeforrulesobject (#20116) (루밀LuMir)7d61b7ffix: add missing scope types toScope.type(#20110) (Pixel998)7a670c3fix: correct rule option typings inrules.d.ts(#20084) (Pixel998)Documentation
b73ab12docs: update examples to usedefineConfig(#20131) (sethamus)31d9392docs: fix typos (#20118) (Pixel998)c7f861bdocs: Update README (GitHub Actions Bot)6b0c08bdocs: Update README (GitHub Actions Bot)91f97c5docs: Update README (GitHub Actions Bot)Chores
12411e8chore: upgrade @ eslint/js@9.36.0 (#20139) (Milos Djermanovic)488cba6chore: package.json update for @ eslint/js release (Jenkins)bac82a2ci: simplify renovate configuration (#19907) (唯然)c00bb37ci: bump actions/labeler from 5 to 6 (#20090) (dependabot[bot])fee751drefactor: usedefaultOptionsin rules (#20121) (Pixel998)1ace67dchore: update example to usedefineConfig(#20111) (루밀LuMir)4821963test: add missing loc information to error objects in rule tests (#20112) (루밀LuMir)b42c42echore: disallow use of deprecatedtypeproperty in core rule tests (#20094) (Milos Djermanovic)7bb498dtest: remove deprecatedtypeproperty from core rule tests (#20093) (Pixel998)e10cf2aci: bump actions/setup-node from 4 to 5 (#20089) (dependabot[bot])5cb0ce4refactor: usemeta.defaultOptionsinpreserve-caught-error(#20080) (Pixel998)f9f7cb5chore: package.json update for eslint-config-eslint release (Jenkins)81764b2chore: updateeslintpeer dependency ineslint-config-eslint(#20079) (Milos Djermanovic)Features
42761fafeat: implement suggestions for no-empty-function (#20057) (jaymarvelz)102f444feat: implement suggestions for no-empty-static-block (#20056) (jaymarvelz)e51fffffeat: addpreserve-caught-errorrule (#19913) (Amnish Singh Arora)Bug Fixes
10e7ae2fix: update uncloneable options error message (#20059) (soda-sorcery)bfa4601fix: ignore empty switch statements with comments in no-empty rule (#20045) (jaymarvelz)dfd11defix: addbeforeandafterto test case types (#20049) (Francesco Trotta)dabbe95fix: correct types forno-restricted-importsrule (#20034) (Milos Djermanovic)ea789c7fix: no-loss-of-precision false positive with uppercase exponent (#20032) (sethamus)Documentation
d265515docs: improve phrasing - "if" → "even if" from getting-started section (#20074) (jjangga0214)a355a0edocs: invert comparison logic for example inno-vardoc page (#20064) (OTonGitHub)5082fc2docs: Update README (GitHub Actions Bot)99cfd7edocs: add missing "the" in rule deprecation docs (#20050) (Josh Goldberg ✨)6ad8973docs: update--no-ignoreand--ignore-patterndocumentation (#20036) (Francesco Trotta)8033b19docs: add documentation for--no-config-lookup(#20033) (Francesco Trotta)Chores
da87f2fchore: upgrade @ eslint/js@9.35.0 (#20077) (Milos Djermanovic)af2a087chore: package.json update for @ eslint/js release (Jenkins)7055764test: removetests/lib/eslint/eslint.config.js(#20065) (Milos Djermanovic)84ffb96chore: update@ eslint-community/eslint-utils(#20069) (Francesco Trotta)d5ef939refactor: remove deprecatedcontext.parserOptionsusage across rules (#20060) (sethamus)1b3881dchore: remove redundant word (#20058) (pxwanglu)Features
0bb777afeat: multithread linting (#19794) (Francesco Trotta)43a5f9efeat: add eslint-plugin-regexp to eslint-config-eslint base config (#19951) (Pixel998)Bug Fixes
9b89903fix: default value of accessor-pairs option in rule.d.ts file (#20024) (Tanuj Kanti)6c07420fix: fix spurious failure in neostandard integration test (#20023) (Kirk Waiblinger)676f4acfix: allow scientific notation with trailing zeros matching exponent (#20002) (Sweta Tanwar)Documentation
0b4a590docs: make rulesdir deprecation clearer (#20018) (Domenico Gemoli)327c672docs: Update README (GitHub Actions Bot)bf26229docs: Fix typo in core-concepts/index.md (#20009) (Tobias Hernstig)2309327docs: fix typo in the "Configuring Rules" section (#20001) (ghazi-git)2b87e21docs: [no-else-return] clarify sample code. (#19991) (Yuki Takada (Yukinosuke Takada))c36570cdocs: Update README (GitHub Actions Bot)Chores
f19ad94chore: upgrade to@ eslint/js@9.34.0(#20030) (Francesco Trotta)b48fa20chore: package.json update for @ eslint/js release (Jenkins)4bce8a2chore: package.json update for eslint-config-eslint release (Jenkins)0c9999crefactor: prefer default options ingrouped-accessor-pairs(#20028) (루밀LuMir)d503f19ci: fixstale.yml(#20010) (루밀LuMir)e2dc67dci: centralizestale.yml(#19994) (루밀LuMir)7093cb8ci: bump actions/checkout from 4 to 5 (#20005) (dependabot[bot])Features
e07820efeat: add global object access detection to no-restricted-globals (#19939) (sethamus)90b050efeat: support explicit resource management inone-var(#19941) (Sweta Tanwar)Bug Fixes
732433cfix: allow any type formeta.docs.recommendedin custom rules (#19995) (Francesco Trotta)e8a6914fix: Fixed potential bug in check-emfile-handling.js (#19975) (諏訪原慶斗)Documentation
34f0723docs: playground button for TypeScript code example (#19671) (Tanuj Kanti)dc942a4docs: Update README (GitHub Actions Bot)5a4b6f7docs: Update no-multi-assign.md (#19979) (Yuki Takada (Yukinosuke Takada))247e156docs: add missing let declarations inno-plusplus(#19980) (Yuki Takada (Yukinosuke Takada))0d17242docs: Update README (GitHub Actions Bot)fa20b9ddocs: Clarify when to open an issue for a PR (#19974) (Nicholas C. Zakas)Build Related
27fa865build: useESLintclass to generate formatter examples (#19972) (Milos Djermanovic)Chores
4258046chore: update dependency @ eslint/js to v9.33.0 (#19998) (renovate[bot])ad28371chore: package.json update for @ eslint/js release (Jenkins)06a22f1test: resolve flakiness in --mcp flag test (#19993) (Pixel998)54920edtest: switch toLinter.ConfiginESLintRulestype tests (#19977) (Francesco Trotta)Features
1245000feat: support explicit resource management in core rules (#19828) (fnx)0e957a7feat: support typescript types in accessor rules (#19882) (fnx)Bug Fixes
960fd40fix: Upgrade @ eslint/js (#19971) (Nicholas C. Zakas)bbf23fafix: Refactor reporting into FileReport (#19877) (Nicholas C. Zakas)d498887fix: bump @ eslint/plugin-kit to 0.3.4 to resolve vulnerability (#19965) (Milos Djermanovic)f46fc6cfix: report only global references in no-implied-eval (#19932) (Nitin Kumar)7863d26fix: remove outdated types inParserOptions.ecmaFeatures(#19944) (ntnyq)3173305fix: update execScript message in no-implied-eval rule (#19937) (TKDev7)Documentation
86e7426docs: Update README (GitHub Actions Bot)Chores
50de1cechore: package.json update for @ eslint/js release (Jenkins)74f01a3ci: unpinjitito version^2.5.1(#19970) (루밀LuMir)2ab1381ci: pinjitito version 2.4.2 (#19964) (Francesco Trotta)b7f7545test: switch to flat config mode inSourceCodetests (#19953) (Milos Djermanovic)f5a35e3test: switch to flat config mode in eslint-fuzzer (#19960) (Milos Djermanovic)e22af8crefactor: useCustomRuleDefinitionTypeinJSRuleDefinition(#19949) (Francesco Trotta)e855717chore: switch performance tests to hyperfine (#19919) (Francesco Trotta)2f73a23test: switch to flat config mode inast-utilstests (#19948) (Milos Djermanovic)c565a53chore: excludefurther_reading_links.jsonfrom Prettier formatting (#19943) (Milos Djermanovic)Features
35cf44cfeat: output full actual location in rule tester if different (#19904) (ST-DDT)a6a6325feat: support explicit resource management inno-loop-func(#19895) (Milos Djermanovic)4682cdcfeat: support explicit resource management inno-undef-init(#19894) (Milos Djermanovic)5848216feat: support explicit resource management ininit-declarations(#19893) (Milos Djermanovic)bb370b8feat: support explicit resource management inno-const-assign(#19892) (Milos Djermanovic)Bug Fixes
07fac6cfix: retry on EMFILE when writing autofix results (#19926) (TKDev7)28cc7abfix: Remove incorrect RuleContext types (#19910) (Nicholas C. Zakas)Documentation
664cb44docs: Update README (GitHub Actions Bot)40dbe2adocs: fix mismatch betweenglobalIgnores()code and text (#19914) (MaoShizhong)5a0069ddocs: Update README (GitHub Actions Bot)fef04b5docs: Update working on issues info (#19902) (Nicholas C. Zakas)Chores
3ddd454chore: upgrade to@ eslint/js@9.31.0(#19935) (Francesco Trotta)d5054e5chore: package.json update for @ eslint/js release (Jenkins)0f4a378chore: update eslint (#19933) (renovate[bot])76c2340chore: bump mocha to v11 (#19917) (루밀LuMir)Bug Fixes
e91bb87fix: allow separate default and named type imports (#19899) (xbinaryx)Documentation
ab7c625docs: Update README (GitHub Actions Bot)dae1e5bdocs: update jsdoc's link (#19896) (JamesVanWaza)Chores
b035f74chore: upgrade to@ eslint/js@9.30.1(#19906) (Francesco Trotta)b3dbc16chore: package.json update for @ eslint/js release (Jenkins)Features
52a5fcafeat: SupportbasePathproperty in config objects (#19879) (Milos Djermanovic)4ab4482feat: addallowSeparateTypeImportsoption tono-duplicate-imports(