forked from farazdagi/rpc-proxy
-
Notifications
You must be signed in to change notification settings - Fork 0
[Snyk] Security upgrade eslint from 7.32.0 to 9.26.0 #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Dustin4444
wants to merge
1
commit into
master
Choose a base branch
from
snyk-fix-d4194db778f0c72bc953b25f4b9203e6
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Upgrading ESLint from v7 to v9 is a major change with many breaking changes. Several other ESLint-related packages in your
devDependenciesare now incompatible and need to be upgraded as well.Specifically:
@typescript-eslint/eslint-pluginand@typescript-eslint/parser(currently^4.16.1) need to be upgraded to v7 or newer to be compatible with ESLint v9.eslint-config-prettier(currently^8.1.0) needs to be upgraded to v9 or newer.Here is a suggestion for the updated dependencies. You might need to adjust versions based on your project's needs, but these should be compatible:
After updating these packages, you will also need to:
yarnto updateyarn.lock, which this PR failed to do.eslint.config.js). While the old.eslintrcformat is still supported, you may encounter issues and should consider migrating.