Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,16 +11,16 @@
"clean": "git checkout data/{**/,}**/logo-white.png"
},
"dependencies": {
"canvas": "^2.11.2",
"canvas": "^3.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Upgrading canvas from v2 to v3 is a major version change that introduces breaking changes. The svg2img dependency, used in your generation script (bin/generate.js), relies on canvas. This upgrade may break the image generation functionality. The code using svg2img or canvas directly will likely need to be updated to be compatible with canvas v3.

"isomorphic-fetch": "^3.0.0"
},
"devDependencies": {
"ava": "^3.15.0",
"axios": "^0.21.1",
"axios-retry": "^3.1.9",
"ethers": "^5.3.0",
"ethers": "^6.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The upgrade of ethers from v5 to v6 is a major version change with extensive breaking changes; the API was largely rewritten. As a devDependency, it might be used in tests or utility scripts. Any part of the codebase using ethers will require significant refactoring to work with v6. If it's an unused dependency, it would be safer to remove it in a separate pull request.

"image-pixels": "^2.2.2",
"lodash": "^4.17.21",
"lodash": "^4.17.23",
"looks-same": "^7.3.0",
"nearest-color": "^0.4.4",
"prompts": "^2.4.1",
Expand Down