Skip to content

[Snyk] Security upgrade canvas from 2.11.2 to 3.0.0 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dustin4444 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Security upgrade canvas from 2.11.2 to 3.0.0 #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"clean": "git checkout data/{**/,}**/logo-white.png"
},
"dependencies": {
"canvas": "^2.11.2",
"canvas": "^3.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Jan 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to canvas v3.0.0 is a major version bump that introduces significant breaking changes. The primary issue is that canvas v3+ is an ESM-only package, which is incompatible with your project's CommonJS module system (require()). This will break your build scripts, specifically bin/generate.js which appears to use canvas for image processing.

To resolve this, you will need to refactor the code that imports canvas to use a dynamic import(). For example:

// In your utils file, instead of:
// const { createCanvas, loadImage } = require('canvas');

// You would use:
const { createCanvas, loadImage } = await import('canvas');

Note that this will likely require making the consuming function async.

Additionally, canvas v3 introduced other breaking API changes, such as making loadImage() and canvas.toBuffer() asynchronous. You will need to carefully review the canvas v3 migration guide and update your code accordingly.

"isomorphic-fetch": "^3.0.0"
},
"devDependencies": {
Expand Down