Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"clean": "git checkout data/{**/,}**/logo-white.png"
},
"dependencies": {
"canvas": "^2.11.2",
"canvas": "^3.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This PR upgrades canvas to a new major version (3.0.0) to fix a security vulnerability. While this is a necessary change, there are two important points to consider:

  1. package-lock.json is not updated. As Snyk noted, package-lock.json was not updated. This is critical and must be fixed before merging. Please run npm install to regenerate the lock file and commit the changes. This ensures that the security fix is applied and that your project has reproducible builds.

  2. Breaking Changes. This is a major version upgrade, which may introduce breaking changes. The Snyk report itself flags this as a breaking change (isBreakingChange: true). Please test the application thoroughly to ensure that the functionality depending on canvas still works as expected after this upgrade.

"isomorphic-fetch": "^3.0.0"
},
"devDependencies": {
Expand Down