Skip to content

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dustin4444 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade eslint from 8.57.0 to 9.0.0 #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"@typescript-eslint/eslint-plugin": "^7.2.0",
"@typescript-eslint/parser": "^7.2.0",
"@vitejs/plugin-react": "^4.2.1",
"eslint": "^8.57.0",
"eslint": "^9.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to ESLint v9 is a major version bump and introduces several critical breaking changes that must be addressed.

1. Update package-lock.json
As noted in the PR description, package-lock.json has not been updated. You must run npm install (or your package manager's equivalent) and commit the resulting changes to package-lock.json to ensure the correct version of eslint is installed.

2. Breaking Changes in ESLint v9
This is a major update with significant changes. Your linting setup will likely break without migration steps. Key changes include:

  • New Default Config System (Flat Config): ESLint v9 now uses eslint.config.js (flat config) by default. The previous .eslintrc.* format is no longer supported out-of-the-box. You must either migrate your configuration to the new format or opt-out by setting the ESLINT_USE_FLAT_CONFIG=false environment variable.
  • Node.js Version: ESLint v9 requires Node.js ^18.18.0 or >=20.0.0. Please ensure your development and CI/CD environments are updated accordingly.
  • Rule Changes: Some rules have been removed from the core and moved to other plugins (e.g., eslint-plugin-jsdoc).

For a comprehensive guide on how to handle these changes, please refer to the official ESLint v9 Migration Guide.

Given the extent of these changes, thorough testing of your linting process is essential after updating.

"eslint-plugin-react-hooks": "^4.6.0",
"eslint-plugin-react-refresh": "^0.4.6",
"typescript": "^5.2.2",
Expand Down