Skip to content

[Snyk] Fix for 13 vulnerabilities #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dustin4444 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Snyk] Fix for 13 vulnerabilities #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3763,19 +3763,19 @@
"@typescript-eslint/eslint-plugin": "6.10.0",
"@typescript-eslint/parser": "6.10.0",
"@vscode/test-electron": "^2.3.8",
"@vscode/test-web": "^0.0.29",
"@vscode/test-web": "^0.0.50",
"assert": "^2.0.0",
"buffer": "^6.0.3",
"constants-browserify": "^1.0.0",
"crypto-browserify": "3.12.0",
"css-loader": "5.1.3",
"esbuild-loader": "4.2.2",
"eslint": "7.22.0",
"eslint": "9.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

Upgrading eslint from version 7 to 9 is a major change that includes significant breaking changes. ESLint v9 no longer supports the traditional .eslintrc.* configuration files. Your project uses .eslintrc.json files (e.g., in webpack.config.js), which will cause your linting and build processes to fail.

You will need to migrate your ESLint configuration to the new flat config format (eslint.config.js). You can find the migration guide here: ESLint Migration Guide.

"eslint-cli": "1.1.1",
"eslint-plugin-import": "2.22.1",
"event-stream": "^4.0.1",
"fork-ts-checker-webpack-plugin": "6.1.1",
"glob": "7.1.6",
"glob": "9.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upgrade of glob from version 7 to 9 is a breaking change. glob v9 is an ECMAScript Module (ESM) and can no longer be imported using require().

Your project script at scripts/preprocess-svg.js uses const globCb = require('glob');, which will now fail. You will need to refactor this script to use dynamic import() or convert it to an ES module to use the new version of glob.

"graphql": "15.5.0",
"graphql-tag": "2.11.0",
"gulp-filter": "^7.0.0",
Expand All @@ -3786,28 +3786,28 @@
"merge-options": "3.0.4",
"minimist": "^1.2.6",
"mkdirp": "1.0.4",
"mocha": "^9.0.1",
"mocha": "^11.0.1",
"mocha-junit-reporter": "1.23.0",
"mocha-multi-reporters": "1.1.7",
"os-browserify": "^0.3.0",
"p-all": "^1.0.0",
"path-browserify": "1.0.1",
"process": "^0.11.10",
"raw-loader": "4.0.2",
"react-testing-library": "7.0.1",
"sinon": "9.0.0",
"react-testing-library": "8.0.1",
"sinon": "16.1.2",
Comment on lines +3789 to +3798
Copy link

@gemini-code-assist gemini-code-assist bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

This PR includes major version upgrades for several key testing libraries:

  • mocha from v9 to v11
  • react-testing-library from v7 to v8
  • sinon from v9 to v16

These are significant jumps that almost certainly include breaking changes to their APIs. It is very likely that your test suite will fail after these upgrades. You will need to carefully review the changelogs for these packages and update your test files accordingly.

"source-map-support": "0.5.19",
"stream-browserify": "^3.0.0",
"style-loader": "2.0.0",
"svg-inline-loader": "^0.8.2",
"temp": "0.9.4",
"terser-webpack-plugin": "5.1.1",
"terser-webpack-plugin": "5.1.4",
"timers-browserify": "^2.0.12",
"ts-loader": "8.0.18",
"tty": "1.0.1",
"typescript": "4.5.5",
"typescript-formatter": "^7.2.2",
"vinyl-fs": "^3.0.3",
"vinyl-fs": "^4.0.0",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The upgrade of vinyl-fs from version 3 to 4 is a breaking change. vinyl-fs v4 is an ECMAScript Module (ESM) and can no longer be imported using require().

Your build script at build/hygiene.js uses const vfs = require('vinyl-fs');, which will now fail. This script needs to be updated to handle ESM packages, for example by using dynamic import().

"webpack": "5.94.0",
"webpack-cli": "4.2.0"
},
Expand Down