Fix on firmware 01.07.01.00 and improve wifi connection setup#12
Merged
DutchDevelop merged 2 commits intoDutchDevelop:mainfrom Dec 29, 2023
Merged
Fix on firmware 01.07.01.00 and improve wifi connection setup#12DutchDevelop merged 2 commits intoDutchDevelop:mainfrom
DutchDevelop merged 2 commits intoDutchDevelop:mainfrom
Conversation
Add filter on MQTT layer to prevent memory overflow
Fix Wifi reconnect loop
DutchDevelop
approved these changes
Dec 29, 2023
DutchDevelop
approved these changes
Dec 29, 2023
aerodomigue
pushed a commit
to aerodomigue/BLLEDController
that referenced
this pull request
Jul 13, 2025
Fix on firmware 01.07.01.00 and improve wifi connection setup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested on ESP32-WROVER. I expect this will work fine on ESP32-WROOM as well, although I have no idea about ESP8266.
I also had to disable merge_firmware.py on my local version as it would not build/deploy with that script. I don't know if this has any side-effects as I have no experience with this.
You can (and probably should) improve the filter further by really only filtering on the specific keys that are required for BLLed to function. Specifically the keys that are checked on in
ParseCallback. If the current fix proves insufficient for ESP8266, improving the filter might fix it for that one