Merged
Conversation
improve filter
Contributor
Author
|
Please note, I have NOT tested this yet. I do expect it to work though based on what the documentation of the arduino json module provides. But please, make sure to test it prior to merging :P |
aerodomigue
pushed a commit
to aerodomigue/BLLEDController
that referenced
this pull request
Jul 13, 2025
Improve MQTT json filter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I used an MQTT sniffer to check what data the bambu printer sends and was astounded by the large payload. I also noticed almost everything is located in "print" part, so to be quite honest I'm not 100% sure how the previous filter solved things.
Either way, this improved filter should really filter out a lot of data (eg "ams" object is quite large depending on amount of AMSes, this is now filtered out and thus in the future it should no longer matter how many AMSes someone has attached to their printer as they're completely ignored).