Compress html to genereate .h with byte array as part of build process#46
Merged
DutchDevelop merged 4 commits intoDutchDevelop:mainfrom Apr 25, 2024
Merged
Conversation
Owner
|
Conflicts must be resolved before merging |
Contributor
Author
|
setupPage.h is deleted from the branch/git as it will be generated now (as setuppage.h) and added .gitignore - not hand edited so it doesn't need to get checked in anymore. the file shows as deleted in the 'files changed' of the PR - i though git would handle this deleting this file as part of the merge? |
Owner
|
Not sure, it doesn't allow me to commit. Doesn't say what the cause is either on github mobile |
Contributor
Author
|
Ok I'll see if I can resolve the conflicts |
Contributor
Author
|
ok, looks like I needed to 'git rm setupPage.h" in addition to deleting the file and adding it to .gitignore. I synced my fork to the latest and did a clean test merge so hopefully this will work now! |
aerodomigue
pushed a commit
to aerodomigue/BLLEDController
that referenced
this pull request
Jul 13, 2025
Compress html to genereate .h with byte array as part of build process
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enhanced the build process to automatically compress html files into the .h file bytearray. For example, setuppage.html -> setuppage.h that contains the compressed bytearray of the setuppage.html. the .h file is only generated if it is missing or the .html file is newer.
I updated the README on the process and the 2 requirements (python, qpdf library).
This should work for other files like updatepage.html by adding them to the list in compress_html.py. I did not do that as I am only testing the pages on the device. Just add the html files to the list.