Added some features by gabidut · Pull Request #9 · DynamXInc/BasicsAddon

gabidut · 2023-12-23T20:04:12Z

DashboardNeedle
- For RPMs and speed
Better speed-display
- Gear
- Speed
- Speed limit

AymericBdy

Merci pour ta pull-request, par contre il y a plusieurs trucs à modifier avant que ça soit intégré au BasicsAddon.

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardNeedleInfo.java

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardNeedleInfo.java

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

src/main/java/fr/dynamx/addons/basics/common/infos/SpeedDisplayInfos.java

YanisBDF

Bonne feature mais quelques soucis de code 👍

YanisBDF · 2024-01-21T22:56:29Z

README.md

+The `DetailToShow` can be one of the following:
+ - GEAR
+ - SPEED
+ - SPEEDLIMITOR


SPEED_LIMITER*

YanisBDF · 2024-01-21T22:56:50Z

README.md

+ - SPEED
+ - SPEEDLIMITOR
+
+It will display the current gear, speed or speedlimitor value at the position.


speed limiter aussi du coup

YanisBDF · 2024-01-21T22:57:17Z

README.md

+
+It will display the current gear, speed or speedlimitor value at the position.
+
+The `CarStartedReact` can be `True` or `False` and will enable or disable the display when the car is started.


ça veut pas dire grand chose "CarStartedReact"

YanisBDF · 2024-01-21T22:59:22Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardNeedleInfo.java

+    public int getNeedleMaxTurn() {
+        return needleMaxTurn;
+    }
+
+    public int getDashboardMaxValue() {
+        return dashboardMaxValue;
+    }
+
+    public EnumDashboardNeedleType getNeedleType() {
+        return needleType;
+    }
+
+    public Vector3f getRotation() {
+        return rotation;
+    }
+
+    public String getNodeDependingOnName() {
+        return this.nodeDependingOnName;
+    }
+


Précision : il est pas configuré sur l'env du BasicsAddon, donc on l'ajoutera surement nous-mêmes

YanisBDF · 2024-01-21T22:59:57Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardNeedleInfo.java

+            if (entityRenderContext.getModel().containsObjectOrNode(DashboardNeedleInfo.this.getObjectName()) && entity.getModuleByType(CarEngineModule.class) != null && DashboardNeedleInfo.this.getPosition() != null) {
+                GlStateManager.pushMatrix();
+                Vector3f pos = DashboardNeedleInfo.this.getPosition();
+                GL11.glTranslatef(pos.x, pos.y, pos.z);


GlStateManager au lei de GL11

YanisBDF · 2024-01-21T23:01:01Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardNeedleInfo.java

+                TextUtils.makeGLRotation(getRotation());
+                switch (DashboardNeedleInfo.this.getNeedleType()) {
+                    case RPM:
+                        int rpms = Math.round(entity.getModuleByType(CarEngineModule.class).getEngineProperty(VehicleEntityProperties.EnumEngineProperties.REVS) * 10000);


Tu peux faire une variable interne de entity.getModuleByType(CarEngineModule.class) et l'utiliser plusieurs fois au lieu de rappeler chaque fois

YanisBDF · 2024-01-21T23:01:27Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

+    protected boolean carStartedReact;
+
+    @PackFileProperty(configNames = "Color", description = "common.color", required = false)
+    protected int[] color = new int[]{10, 10, 10};


Utilise un Vector3f please

YanisBDF · 2024-01-21T23:01:38Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

+    public Vector3f getRotation() {
+        return rotation;
+    }
+
+    public int[] getColor() {
+        return color;
+    }
+
+    public boolean isCarStartedReact() {
+        return carStartedReact;
+    }
+
+    public String getFont() {
+        return font;
+    }
+
+    public EnumDashboardTextType getDetailToShow() {
+        return detailToShow;
+    }


YanisBDF · 2024-01-21T23:02:02Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

+        public void render(@Nullable T entity, EntityRenderContext entityRenderContext, A packInfo) {
+            if (entity == null) return;
+            if (DashboardTextInfos.this.getRotation() != null) {
+                if (entity.getModuleByType(CarEngineModule.class).getPhysicsHandler().getEngine().isStarted() && DashboardTextInfos.this.isCarStartedReact()) {


Meme chose pour entity.getModuleByType(CarEngineModule.class)

YanisBDF · 2024-01-21T23:02:34Z

src/main/java/fr/dynamx/addons/basics/common/infos/DashboardTextInfos.java

+                            break;
+                        case SPEEDLIMITOR:
+                            int tempvalue = Math.round(entity.getModuleByType(CarEngineModule.class).getSpeedLimit());
+                            if (tempvalue != 0 & tempvalue < 10000000) value = String.valueOf(tempvalue);


tu peux utiliser une condition ternaire et peut être utiliser Integer.MAX_VALUE au lieu de 100000

gabidut added 4 commits December 23, 2023 15:57

Small try

6eee2ef

Needle totally works

bd23c7b

Added dashboard details & added infos on readme

27ae1a8

(corrected readme)

8256bc0

AymericBdy reviewed Dec 23, 2023

View reviewed changes

gabidut added 4 commits December 24, 2023 12:08

Cleaning code

be91451

Added enums

a3242cc

Added switchs

707a447

Small correction*

f81f6b5

gabidut requested a review from AymericBdy December 26, 2023 16:24

YanisBDF reviewed Jan 21, 2024

View reviewed changes


		It will display the current gear, speed or speedlimitor value at the position.

		The `CarStartedReact` can be `True` or `False` and will enable or disable the display when the car is started.

Conversation

gabidut commented Dec 23, 2023

Uh oh!

AymericBdy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

YanisBDF left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants