Open
Conversation
AymericBdy
reviewed
Mar 11, 2026
src/main/java/fr/dynamx/common/physics/world/BasePhysicsWorld.java
Outdated
Show resolved
Hide resolved
AymericBdy
reviewed
Mar 11, 2026
| int index = powerGraph.getControlPoints().size() - 1; | ||
| int size = powerGraph.getControlPoints().size(); | ||
| if (size < 2) { | ||
| return size == 1 ? powerGraph.getControlPoints().get(0).y : 0; |
Member
There was a problem hiding this comment.
I don't get why this is necessary. The clamp you added after isn't sufficient?
Author
There was a problem hiding this comment.
I just added it to prevent an IndexOutOfBoundsException. If the graph is empty or only has 1 point, the size - 2 logic in the clamp below results in a negative index and crashes the game. I think this just bails out safely before any of that happens.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Render bug between DynamX and Custom Player Models - fixed
Items moved strangely in inventory
Fix evaluateSpline bounds checking and interpolation edge cases and Improve error handling in physics simulation loop