Merged
Conversation
Continued rename effort through Math category. This includes renames in the JSON because of invalid characters
This represents the rename effort through the rest of the nodes (excluding Revit nodes as there seems to be another issue at hand)
Finished renaming the Revit nodes to support what they actually are in the JSON.
Racel
suggested changes
Dec 4, 2018
Racel
left a comment
Racel
left a comment
There was a problem hiding this comment.
Only one thing I can see that is wrong. Just ping me when it is fixed and I will merge and deploy around tomorrow morning.
Member
Author
|
@Racel change complete! |
Racel
approved these changes
Dec 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renamed several DYNs/JPGs to reflect how they are actually named in the JSON file. This was an error carried over from previous naming convention. Also fixed some folder structures. This represents a full check of all categories aside from the Revit ones.