[Feat] Firebase Eventlogger #329

HI-JIN2 · 2025-09-06T02:39:45Z

Summary

파이어베이스의 event_log를 기록합니다

Describe your changes

https://www.notion.so/eat-ssu/1d2eeef75a16813ca490db6ddf528c26?source=copy_link
위 노션 문서에서 정의한 Firebase Event Logging에 대한 작업을 하였습니다.

참고자료

https://kwongdevelop.tistory.com/60
todaywhat/TodayWhat-Aos#67

Issue

Resolves # None

To reviewers

위젯 브랜치가 머지 되지 않은 상황에서 파생 브랜치를 파서 그런지... 현 develop을 기준으로 리베이스 하였음에도 불구하고 커밋기록이 그대로 남아있네요.. ㅜㅜ 다음에는 좀더 신경쓰도록 하겠습니다. (file change에서는 현재 작업에 해당하는 파일들만 있습니다!!! 위젯 작업은 없음!!)
순수 이번 작업에 해당하는 커밋은 하기와 같습니다.

2. 제훈님이 저번에 말씀해주신 위젯에서 Restraunt enum을 넘기도록 하는 방식의 리팩토링이 일부 있습니다.

Copilot

Pull Request Overview

This PR introduces Firebase Event Logging functionality to the EatSSU Android app. The implementation creates a centralized EventLogger for tracking user interactions and refactors existing enum classes into a shared core:common module.

Implements Firebase Analytics integration with comprehensive event tracking throughout the app
Creates a new core:common module to house shared enums and the EventLogger
Refactors existing enum classes from app/data/enums to core:common/enums for better code organization

Reviewed Changes

Copilot reviewed 56 out of 57 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
core/common/src/main/java/com/eatssu/common/EventLogger.kt	Central Firebase Analytics event logging implementation
core/common/src/main/java/com/eatssu/common/enums/*	Relocated enum classes (Restaurant, Time, MenuType, etc.) from app module
Multiple app files	Updated import statements to reference relocated enums from core:common
Widget-related files	Enhanced widget functionality to pass Restaurant enum and log events
UI components	Added event logging calls throughout cafeteria, map, and review flows

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

core/common/src/main/java/com/eatssu/common/EventLogger.kt

Copilot · 2025-09-07T15:37:51Z

core/common/src/main/java/com/eatssu/common/EventLogger.kt

+        likes: Long,
+        photoAttached: Boolean,
+    ) {
+        firebaseAnalytics.logEvent("complete_review_v1") {


The event name should be 'complete_review_v2' for the completeReviewV2 function, not 'complete_review_v1'.

Suggested change

firebaseAnalytics.logEvent("complete_review_v1") {

firebaseAnalytics.logEvent("complete_review_v2") {

ㅇ코파일럿 코멘트처럼 추후에 completeReviewV2 함수에서 왜 complete_review_v1를 호출하는지 헷갈릴 수도 있을 것 같아요.
백엔드와 협업해서 complete_review 이름 자체를 공통되게 하나로 변경하거나, 이름을 v1 v2 나뉘게 해야 할 것 같아요!

core/common/src/main/java/com/eatssu/common/EventLogger.kt

core/common/src/main/java/com/eatssu/common/enums/Time.kt

Copilot · 2025-09-07T15:37:52Z

.../java/com/eatssu/android/presentation/cafeteria/review/write/menu/VariableMenuPickAdapter.kt

+class
+VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :


The class declaration is unnecessarily split across two lines. This should be on a single line for better readability.

Suggested change

class

VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :

class VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :

app/src/main/AndroidManifest.xml

core/common/src/main/java/com/eatssu/common/EventLogger.kt

PeraSite · 2025-09-08T00:53:28Z

core/common/src/main/java/com/eatssu/common/EventLogger.kt

+        likes: Long,
+        photoAttached: Boolean,
+    ) {
+        firebaseAnalytics.logEvent("complete_review_v1") {


ㅇ코파일럿 코멘트처럼 추후에 completeReviewV2 함수에서 왜 complete_review_v1를 호출하는지 헷갈릴 수도 있을 것 같아요.
백엔드와 협업해서 complete_review 이름 자체를 공통되게 하나로 변경하거나, 이름을 v1 v2 나뉘게 해야 할 것 같아요!

core/common/src/main/java/com/eatssu/common/enums/Restaurant.kt

app/src/main/java/com/eatssu/android/presentation/login/IntroActivity.kt

PeraSite

고생하셨습니당!!

kangyuri1114

오타가 있는 것 같아 리뷰 남깁니다..!

kangyuri1114 · 2025-09-08T13:54:55Z

app/src/main/java/com/eatssu/android/presentation/map/MapFragmentView.kt

-            FilterType.All -> viewModel.loadPartnerships()
+            FilterType.All -> {
+                viewModel.loadPartnerships()
+                EventLogger.clickMap()


해당 이벤트가 "‘지도’ 클릭 - 제휴지도 이용 빈도"으로 노션에 써져있던데
토글 선택 시에만 이벤트가 수집되는 것 같아서요
바텀 바에서 지도 클릭 시에도 디폴트가 전체 제휴 지도 화면이 보여지니까 포함되어야 하지 않을까요??
아니면 그냥 '내제휴 / 전체제휴' 이용 빈도를 보기 위한 이벤트 일까요??

테스트 결과, 토글 클릭 때에만 수집되지 않고, 바텀네비로 진입시에도 click_map이 호출됩니당~!

core/common/src/main/java/com/eatssu/common/enums/LaunchPath.kt

HI-JIN2 added 30 commits September 6, 2025 22:17

add: Glance 기본 세팅

a0970dc

add: glance preview 추가

2f3b943

feat: glance widget UI 구현 중

5bc433d

feat: worker 및 datastore

2655bf6

feat: lazyColumn 구현 완료

1c77fbc

chore: 리시버 정리

28a816e

feat: 변경된 디자인 4*2

dc2f3d9

setting: hilt compiler 추가

527f6b5

feat: Worker에서 Usecase로 API 호출하고, datastore에 저장

da1f4c4

feat: 위젯 UI BaseLayout을 재활용 하도록 수정

bd7171c

feat: 더미가 아닌 실제 데이터를 연결

9a48c25

chore: 코드 정리

95d4c43

feat: data class WidgetMeal 만듦

db3cbf9

chore: 코드 정리

1ea0593

chore: enum -> 한글화 함수 추가

613d617

feat: 작은 위젯 추가

9b08114

feat: 위젯 설정 화면

896ea76

add: WidgetSettingScreen

212a87b

setting: 라이브러리 정리 (hilt)

230c947

feat: 일단 빌드 됨

7353143

feat: json 파싱 됨

55d5a9e

add: Glance 기본 세팅

6642cd5

add: glance preview 추가

e7ed126

feat: glance widget UI 구현 중

a76c160

feat: worker 및 datastore

b5564ee

feat: lazyColumn 구현 완료

d632cfa

chore: 리시버 정리

ac392d5

feat: 변경된 디자인 4*2

945cf3e

feat: Worker에서 Usecase로 API 호출하고, datastore에 저장

d3762b2

feat: 위젯 UI BaseLayout을 재활용 하도록 수정

919f4c0

feat: logging select_mealtype

6578c60

HI-JIN2 force-pushed the feat/logging branch from c141806 to 6578c60 Compare September 6, 2025 13:28

HI-JIN2 added 9 commits September 6, 2025 22:37

chore: 리베이스 실수

6a45e6f

chore: 리베이스 실수2

dbc3ce2

feat: logging click_map, click_map_mine, click_partner_restaurant

487f2f6

feat: logging click_menu

fefde9e

feat: logging add_widget

9826860

chore: analytics debug 수집 안되게 수정

87a0abd

feat: logging remove_widget

8161a52

feat: logging complete_review_v1

9cc3c02

refactor: Restaurant enum을 바로 넘기도록 리팩토링

a78a138

HI-JIN2 marked this pull request as ready for review September 7, 2025 15:33

HI-JIN2 requested review from PeraSite, Copilot and kangyuri1114 and removed request for Copilot September 7, 2025 15:36

Copilot AI reviewed Sep 7, 2025

View reviewed changes

HI-JIN2 added 2 commits September 8, 2025 00:43

chore: 최종 문서 검토

4340f4e

chore: apply Copilt review

a20fd85

HI-JIN2 self-assigned this Sep 7, 2025

PeraSite requested changes Sep 8, 2025

View reviewed changes

HI-JIN2 added 2 commits September 8, 2025 17:29

chore: separate LaunchPath other files

1b76569

chore: 코드리뷰 반영

b0a4468

HI-JIN2 requested a review from PeraSite September 8, 2025 11:17

PeraSite approved these changes Sep 8, 2025

View reviewed changes

kangyuri1114 reviewed Sep 8, 2025

View reviewed changes

chore: 오타 수정

14854b7

HI-JIN2 merged commit ab6585a into develop Sep 8, 2025
1 check passed

HI-JIN2 deleted the feat/logging branch September 8, 2025 14:34

	firebaseAnalytics.logEvent("complete_review_v1") {
	firebaseAnalytics.logEvent("complete_review_v2") {

		class
		VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :

	class
	VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :
	class VariableMenuPickAdapter(private val menuList: List<MenuMini>?) :

[Feat] Firebase Eventlogger #329

[Feat] Firebase Eventlogger #329

Uh oh!

Conversation

HI-JIN2 commented Sep 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Describe your changes

참고자료

Issue

To reviewers

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

PeraSite Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Sep 7, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PeraSite Sep 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

PeraSite left a comment

Choose a reason for hiding this comment

Uh oh!

kangyuri1114 left a comment

Choose a reason for hiding this comment

Uh oh!

kangyuri1114 Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

HI-JIN2 Sep 8, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

HI-JIN2 commented Sep 6, 2025 •

edited

Loading

PeraSite Sep 8, 2025 •

edited

Loading

PeraSite Sep 8, 2025 •

edited

Loading