-
Notifications
You must be signed in to change notification settings - Fork 0
[Fix] 디버그와 릴리즈 앱 동시 설치 기능 추가 수정 #331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @PeraSite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
이 PR은 기존 풀 리퀘스트에서 누락되었던 중요한 빌드 구성을 올바르게 적용하는 것을 목표로 합니다. 디버그 빌드의 애플리케이션 ID 접미사를 활성화하고 디버그 전용 애플리케이션 이름을 설정함으로써, 개발 환경에서 앱의 식별 및 관리가 용이해지도록 개선합니다. 이는 이슈 #328을 해결합니다.
Highlights
- 디버그 애플리케이션 ID 접미사 활성화: app/build.gradle.kts 파일에서 디버그 빌드 타입에 대한 applicationIdSuffix = ".debug" 설정의 주석을 해제하여 디버그 버전의 애플리케이션 ID가 올바르게 지정되도록 했습니다.
- 디버그 전용 앱 이름 설정: app/src/debug/res/values/strings.xml 파일을 새로 추가하여 디버그 빌드에서만 사용될 애플리케이션 이름(app_name)을 "없슈"로 설정했습니다.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
이번 PR은 디버그 빌드 설정을 올바르게 수정하는 것을 목표로 합니다. applicationIdSuffix를 활성화하여 디버그 빌드와 릴리스 빌드를 구분할 수 있도록 한 점은 좋습니다. 다만, 디버그 빌드에서 사용되는 앱 이름이 다소 모호하여, 보다 명확한 이름으로 변경하는 것을 제안하는 리뷰 의견을 남겼습니다.
| @@ -0,0 +1,3 @@ | |||
| <resources> | |||
| <string name="app_name">없슈</string> | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
너가 뭔데!!!!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
진짜 유머 감각 없다 제미나이
HI-JIN2
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
따봉드립니다~
Summary
기존 PR에서 반영되지 않았던 내용 반영 및 빌드 오류 해결
Issue