-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 닉네임 제한 16자로 변경 #394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @PeraSite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 Pull Request는 사용자 닉네임의 최대 길이를 8자에서 16자로 늘려 사용자들이 더 다양하고 개성 있는 닉네임을 설정할 수 있도록 합니다. 이는 닉네임 입력 필드의 UI 제한, 백엔드 유효성 검사 로직, 그리고 사용자에게 표시되는 안내 메시지를 일관되게 업데이트하는 것을 포함합니다. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
닉네임 글자 수 제한을 16자로 변경하는 수정 사항 잘 보았습니다. 로직, 레이아웃, 문자열 리소스에 일관되게 변경 사항이 적용되었습니다. 코드의 유지보수성을 높이기 위해 몇 가지 개선점을 제안합니다. 구체적으로, 닉네임 길이 제한 값을 상수로 관리하고, UI 텍스트에 이 값을 하드코딩하는 대신 문자열 포맷팅을 사용하는 것입니다.
app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the nickname character limit from 8 to 16 characters to support "cute nicknames" as mentioned in the description. The change involves updating validation logic, UI elements, and string resources consistently across the codebase.
- Updated nickname length validation from 2-8 characters to 2-16 characters
- Renamed UI element IDs and string resources for better semantic naming
- Updated all references to use the new naming conventions
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app/src/main/res/values/strings.xml | Updated string resource name and text to reflect new 16-character limit |
| app/src/main/res/layout/activity_user_info.xml | Updated maxLength attribute and renamed TextView ID for consistency |
| app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt | Updated validation logic and UI element references to support 16-character limit |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
닉네임 최대 길이 16글자로 바뀐 것 확인하였습니다!
디자인 팀과 연계하여, 16글자 닉네임을 가진 사람의 리뷰나 마이페이지에서 줄넘김 없는지 등 확인해봐야할 것 같습니다
PR에 이미지가 깨지는게 요거 쫌만 신경써 주시면 감사하겠습니다!
수고하셨슴다 👍
app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt
Outdated
Show resolved
Hide resolved
제미니가 이야기한 매직 넘버 수정하고, 닉네임 1~2자리까지 줄여서 오류 띄웠다가 다시 2글자 초과로 늘려도 여전히 테두리가 빨간색이던 문제 수정했습니다! 머지할게용 PR 이미지 깨지는 건 어떤 것 말씀하시는걸까요? |
Summary
귀여운 닉네임 도입으로 기존 8자 제한에서 16자로 변경
Describe your changes
Issue
To reviewers