Skip to content

Conversation

@PeraSite
Copy link
Member

Summary

귀여운 닉네임 도입으로 기존 8자 제한에서 16자로 변경

Describe your changes

image

Issue

  • Resolves #

To reviewers

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @PeraSite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

이 Pull Request는 사용자 닉네임의 최대 길이를 8자에서 16자로 늘려 사용자들이 더 다양하고 개성 있는 닉네임을 설정할 수 있도록 합니다. 이는 닉네임 입력 필드의 UI 제한, 백엔드 유효성 검사 로직, 그리고 사용자에게 표시되는 안내 메시지를 일관되게 업데이트하는 것을 포함합니다.

Highlights

  • 닉네임 최대 길이 확장: 사용자 닉네임의 최대 길이를 기존 8자에서 16자로 확장했습니다.
  • 유효성 검사 로직 업데이트: 닉네임 입력 필드의 유효성 검사 로직을 2~16자 범위로 조정했습니다.
  • UI 및 문자열 리소스 변경: 닉네임 입력 필드의 maxLength 속성 및 관련 안내 메시지 문자열 리소스가 업데이트되었습니다. 또한, 닉네임 상태를 표시하는 TextView의 ID가 tv_nickname_2_8에서 tv_nickname_status로 변경되었습니다.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

닉네임 글자 수 제한을 16자로 변경하는 수정 사항 잘 보았습니다. 로직, 레이아웃, 문자열 리소스에 일관되게 변경 사항이 적용되었습니다. 코드의 유지보수성을 높이기 위해 몇 가지 개선점을 제안합니다. 구체적으로, 닉네임 길이 제한 값을 상수로 관리하고, UI 텍스트에 이 값을 하드코딩하는 대신 문자열 포맷팅을 사용하는 것입니다.

@PeraSite PeraSite self-assigned this Oct 15, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the nickname character limit from 8 to 16 characters to support "cute nicknames" as mentioned in the description. The change involves updating validation logic, UI elements, and string resources consistently across the codebase.

  • Updated nickname length validation from 2-8 characters to 2-16 characters
  • Renamed UI element IDs and string resources for better semantic naming
  • Updated all references to use the new naming conventions

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
app/src/main/res/values/strings.xml Updated string resource name and text to reflect new 16-character limit
app/src/main/res/layout/activity_user_info.xml Updated maxLength attribute and renamed TextView ID for consistency
app/src/main/java/com/eatssu/android/presentation/mypage/userinfo/UserInfoActivity.kt Updated validation logic and UI element references to support 16-character limit

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@HI-JIN2 HI-JIN2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

닉네임 최대 길이 16글자로 바뀐 것 확인하였습니다!

디자인 팀과 연계하여, 16글자 닉네임을 가진 사람의 리뷰나 마이페이지에서 줄넘김 없는지 등 확인해봐야할 것 같습니다

PR에 이미지가 깨지는게 요거 쫌만 신경써 주시면 감사하겠습니다!

수고하셨슴다 👍

@PeraSite
Copy link
Member Author

닉네임 최대 길이 16글자로 바뀐 것 확인하였습니다!

디자인 팀과 연계하여, 16글자 닉네임을 가진 사람의 리뷰나 마이페이지에서 줄넘김 없는지 등 확인해봐야할 것 같습니다

PR에 이미지가 깨지는게 요거 쫌만 신경써 주시면 감사하겠습니다!

수고하셨슴다 👍

제미니가 이야기한 매직 넘버 수정하고, 닉네임 1~2자리까지 줄여서 오류 띄웠다가 다시 2글자 초과로 늘려도 여전히 테두리가 빨간색이던 문제 수정했습니다! 머지할게용

PR 이미지 깨지는 건 어떤 것 말씀하시는걸까요?

@PeraSite PeraSite merged commit c762529 into develop Oct 17, 2025
1 check passed
@PeraSite PeraSite deleted the feat/new-nickname branch October 17, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants