-
Notifications
You must be signed in to change notification settings - Fork 0
[Chore] README 기여자에 정제훈 추가 #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @PeraSite, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! 이 PR은 Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
안녕하세요. README에 기여자를 추가하는 작업을 해주셨네요. 전반적으로 좋은 변경이지만, 기여자 프로필 이미지의 URL과 대체 텍스트(alt text)를 개선하면 더 좋을 것 같습니다. 아래에 자세한 리뷰 코멘트를 남겼으니 확인 부탁드립니다.
| |2022.11~현재|2022.11~2024.02|2025.02~현재| | ||
| |[유진](https://github.com/HI-JIN2)|[이현지](https://github.com/Amepistheo)|[강유리](https://github.com/kangyuri1114)|[정제훈](https://github.com/PeraSite)| | ||
| |:---:|:---:|:---:|:---:| | ||
| |||| |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
기여자 프로필 이미지에 user-attachments URL을 사용하셨는데, 이 URL은 영구적이지 않을 수 있어 나중에 이미지가 보이지 않게 될 수 있습니다. 각 기여자의 GitHub 프로필 이미지 URL(예: https://github.com/<username>.png)을 직접 사용하는 것이 더 안정적입니다.
또한, 이미지의 대체 텍스트(alt text)를 image 대신 각 기여자의 이름으로 설정하면 웹 접근성을 향상시킬 수 있습니다.
| |||| | |
| ||||| |
Summary
서너달이 지났지만 이제서야 추가하기
Describe your changes
Issue
To reviewers