Added documentation on how to build on top of EESSI#118
Merged
ocaisa merged 7 commits intoEESSI:mainfrom Nov 7, 2023
Merged
Conversation
trz42
requested changes
Oct 26, 2023
Collaborator
trz42
left a comment
trz42
left a comment
There was a problem hiding this comment.
Overall looks good. Left a few comments.
Haven't tried it yet.
added 2 commits
October 30, 2023 15:14
…from Thomas into account
…sure it's clear the EESSI environment needs to be loaded before loading the module that was build on top
trz42
previously requested changes
Nov 3, 2023
Collaborator
trz42
left a comment
trz42
left a comment
There was a problem hiding this comment.
Just tested the procedure. It worked after doing one important swap of commands in the configuration. Added two minor suggestions.
Should be easy to change.
Co-authored-by: Thomas Röblitz <trz42@users.noreply.github.com>
ocaisa
approved these changes
Nov 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed on Slack, there is much we can do to make this easier with a module. Still, I think it's useful to have some documentation in place as soon as we can. We can then take it from there if there are improvements :)